Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25817
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.142.136.132 cause and error)
Message-ID: <012c01c6e0a0$f7cf1250$0201a8c0@pc1>
To: <internals@lists.php.net>
Date: Mon, 25 Sep 2006 07:48:54 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: [PATCH] Error message cleanup
From: php_lists@realplain.com ("Matt W")

Hi,

Don't know if someone wants to check this out and apply it before 5.2's
release, or whether you want it at all. ;-)  I just noticed how many of the
php_error_docref()'s still have a period (".") at the end of the text,
resulting in "... error message. in <file> on line <line>"  Looks
better/consistent without a period, and I think that's how you want it now,
isn't it?

I don't know if my regex search found all occurrences, but I fixed up the
files I found.  The only changes were removing a trailing period (or a space
in a few places), and a couple typos I noticed in the ones I changed -- 
"interger", "can not" -> "cannot", I think that's about all.  Also updated
the necessary test files I found, to reflect the changes.  I think (hope)
everything's OK, but haven't tested it!

There looks to be 209/188 changes in 5.2/6, respectively.  BTW, 5.2's
ext/soap/tests/bugs/bug31755.phpt must be screwed up (new lines) since the
diff is deleting every line first...

http://realplain.com/php/error_messages.diff
http://realplain.com/php/error_messages_5_2.diff


Thanks,
Matt