Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25812 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17350 invoked by uid 1010); 24 Sep 2006 21:44:51 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 17335 invoked from network); 24 Sep 2006 21:44:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Sep 2006 21:44:51 -0000 Authentication-Results: pb1.pair.com smtp.mail=alexei@net24.co.nz; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=alexei@net24.co.nz; sender-id=unknown Received-SPF: error (pb1.pair.com: domain net24.co.nz from 210.55.4.16 cause and error) X-PHP-List-Original-Sender: alexei@net24.co.nz X-Host-Fingerprint: 210.55.4.16 srv.exchange.net24.net.nz Windows 2000 SP4, XP SP1 Received: from [210.55.4.16] ([210.55.4.16:28358] helo=srv.exchange.net24.net.nz) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3E/7E-14982-25CF6154 for ; Sun, 24 Sep 2006 17:44:51 -0400 Received: from [210.55.30.54] ([210.55.30.54]) by srv.exchange.net24.net.nz with Microsoft SMTPSVC(6.0.3790.1830); Mon, 25 Sep 2006 09:43:23 +1200 Message-ID: <4516FC4F.9020402@net24.co.nz> Date: Mon, 25 Sep 2006 09:44:47 +1200 User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: internals@lists.php.net References: <4516F492.8010500@net24.co.nz> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 24 Sep 2006 21:43:23.0640 (UTC) FILETIME=[75CB3780:01C6E022] Subject: Re: [PHP-DEV] [PATCH] Net_URL From: alexei@net24.co.nz (Alexei) Thanks Jan Sorry guys, description of how to submit patches was a bit confusing on pear website. Alexei Jan Lehnardt wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hey Alexei, > Thanks you for your patch! I committed it. > > For future reference however, these patches should go into > the bug system[1] and there is a dedicated PEAR development > related list[2]. > > Best, > Jan > - -- > [1] > http://pear.php.net/bugs/search.php?cmd=display&package_name%5B%5D=Net_URL > [2] pear-dev@lists.php.net > > On Sun 24 Sep 2006, at 24 Sep 23:11, Alexei wrote: > >> Here is a patch for >> >> // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $ >> // >> // Net_URL Class >> >> Misspelled variable in function Net_URL::setProtocol() >> >> >> 418c418 >> < $this->port = is_null($port) ? >> $this->getStandardPort($protocal) : $port; >> --- >> > $this->port = is_null($port) ? >> $this->getStandardPort($protocol) : $port; >> >> --PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.3 (Darwin) > > iD8DBQFFFviH7KW8t7uWVrARAh0xAJ9rAm/qs/K+lYcN7GFnzgt6ksCz2wCgxRcY > uqZaLNQ9ZFt1vhu2lPiuxzU= > =Df9R > -----END PGP SIGNATURE----- >