Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25811 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14037 invoked by uid 1010); 24 Sep 2006 21:29:42 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 14022 invoked from network); 24 Sep 2006 21:29:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Sep 2006 21:29:42 -0000 Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 212.227.48.61 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 212.227.48.61 mayflowerholding.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.227.48.61] ([212.227.48.61:49496] helo=s15175637.rootmaster.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C0/ED-14982-3C8F6154 for ; Sun, 24 Sep 2006 17:29:41 -0400 Received: (qmail 15768 invoked by uid 2520); 24 Sep 2006 23:29:37 +0200 Received: from 62.245.162.229 by s15175637 (envelope-from , uid 2020) with qmail-scanner-1.25st (uvscan: v4.4.00/v4858. spamassassin: 3.1.4. perlscan: 1.25st. Clear:RC:0(62.245.162.229):SA:0(1.3/5.0):. Processed in 1.189752 secs); 24 Sep 2006 21:29:37 -0000 X-Spam-Status: No, hits=1.3 required=5.0 X-Spam-Level: + Received: from ppp-62-245-162-229.dynamic.mnet-online.de (HELO ?192.168.1.104?) (62.245.162.229) by mayflowerholding.com with SMTP; 24 Sep 2006 23:29:36 +0200 Message-ID: <4516F876.8050709@schlueters.de> Date: Sun, 24 Sep 2006 23:28:22 +0200 User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Alexei CC: internals@lists.php.net References: <4516F492.8010500@net24.co.nz> In-Reply-To: <4516F492.8010500@net24.co.nz> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Net_URL From: johannes@schlueters.de (Johannes Schlueter) Please send this to an PEAR list or report a bug at pear.php.net, internals is the wrong place for this. And as a related note: diff -u is way better readable and preferred. johannes Alexei wrote: > Here is a patch for > > // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $ > // > // Net_URL Class > > Misspelled variable in function Net_URL::setProtocol() > > > 418c418 > < $this->port = is_null($port) ? > $this->getStandardPort($protocal) : $port; > --- > > $this->port = is_null($port) ? > $this->getStandardPort($protocol) : $port; >