Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25810 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13060 invoked by uid 1010); 24 Sep 2006 21:28:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 13045 invoked from network); 24 Sep 2006 21:28:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Sep 2006 21:28:50 -0000 Authentication-Results: pb1.pair.com header.from=jan@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jan@php.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain php.net from 83.97.50.139 cause and error) X-PHP-List-Original-Sender: jan@php.net X-Host-Fingerprint: 83.97.50.139 jan.prima.de FreeBSD 4.6-4.9 Received: from [83.97.50.139] ([83.97.50.139:4998] helo=jan.prima.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3B/AD-14982-098F6154 for ; Sun, 24 Sep 2006 17:28:49 -0400 Received: from [192.168.178.20] (p508F89F0.dip0.t-ipconnect.de [::ffff:80.143.137.240]) (AUTH: LOGIN jan, SSL: TLSv1/SSLv3,128bits,RC4-SHA) by jan.prima.de with esmtp; Sun, 24 Sep 2006 21:28:45 +0000 In-Reply-To: <4516F492.8010500@net24.co.nz> References: <4516F492.8010500@net24.co.nz> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: Cc: internals@lists.php.net Content-Transfer-Encoding: 7bit Date: Sun, 24 Sep 2006 23:28:38 +0200 To: Alexei X-Pgp-Agent: GPGMail 1.1.2 (Tiger) X-Mailer: Apple Mail (2.752.2) Subject: Re: [PHP-DEV] [PATCH] Net_URL From: jan@php.net (Jan Lehnardt) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey Alexei, Thanks you for your patch! I committed it. For future reference however, these patches should go into the bug system[1] and there is a dedicated PEAR development related list[2]. Best, Jan - -- [1] http://pear.php.net/bugs/search.php?cmd=display&package_name%5B% 5D=Net_URL [2] pear-dev@lists.php.net On Sun 24 Sep 2006, at 24 Sep 23:11, Alexei wrote: > Here is a patch for > > // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $ > // > // Net_URL Class > > Misspelled variable in function Net_URL::setProtocol() > > > 418c418 > < $this->port = is_null($port) ? $this->getStandardPort > ($protocal) : $port; > --- > > $this->port = is_null($port) ? $this->getStandardPort > ($protocol) : $port; > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (Darwin) iD8DBQFFFviH7KW8t7uWVrARAh0xAJ9rAm/qs/K+lYcN7GFnzgt6ksCz2wCgxRcY uqZaLNQ9ZFt1vhu2lPiuxzU= =Df9R -----END PGP SIGNATURE-----