Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25767
Return-Path: <derick@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 42095 invoked by uid 1010); 19 Sep 2006 21:28:38 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 42080 invoked from network); 19 Sep 2006 21:28:38 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 19 Sep 2006 21:28:38 -0000
Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain php.net from 82.94.239.5 cause and error)
X-PHP-List-Original-Sender: derick@php.net
X-Host-Fingerprint: 82.94.239.5 jdi.jdi-ict.nl Linux 2.5 (sometimes 2.4) (4)
Received: from [82.94.239.5] ([82.94.239.5:39976] helo=jdi.jdi-ict.nl)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id DE/EC-54096-50160154 for <internals@lists.php.net>; Tue, 19 Sep 2006 17:28:37 -0400
Received: from localhost (localhost [127.0.0.1])
	by jdi.jdi-ict.nl (8.13.7/8.12.11) with ESMTP id k8JLSXBj019672;
	Tue, 19 Sep 2006 23:28:33 +0200
Date: Tue, 19 Sep 2006 23:28:24 +0200 (CEST)
X-X-Sender: derick@localhost
To: Dan Scott <denials@gmail.com>
cc: Ilia Alshanetsky <ilia@prohost.org>, pierre.php@gmail.com,
        PHP Developers Mailing List <internals@lists.php.net>, rasmus@php.net
In-Reply-To: <fbb0d11d0609161028p207341b5mc2444e7b83ab19c@mail.gmail.com>
Message-ID: <Pine.LNX.4.62.0609192327410.3563@localhost>
References: <20060916125431.42e9a5dd@pierre-u64> 
 <fbb0d11d0609160835u1cef678awbdcf99736b16513d@mail.gmail.com> 
 <94DEA960-10E5-4796-8570-BB66520FC27C@prohost.org>
 <fbb0d11d0609161028p207341b5mc2444e7b83ab19c@mail.gmail.com>
X-Face: "L'&?Ah3MYF@FB4hU'XhNhLB]222(Lbr2Y@F:GE[OO;"F5p>qtFBl|yVVA&D{A(g3[C}mG:199P+5C'v.M/u@Z\![0b:Mv.[l6[uWl'
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] ext/filter, Final API proposal
From: derick@php.net (Derick Rethans)

On Sat, 16 Sep 2006, Dan Scott wrote:

> On 16/09/06, Ilia Alshanetsky <ilia@prohost.org> wrote:
> >
> > On 16-Sep-06, at 11:35 AM, Dan Scott wrote:
> >
> > > Minor: the general structure of the function names are
> > > <prefix>_<verb>_<noun>, so it would be more consistent if this was
> > > 'input_list_filters'.
> > >
> > > Overall: +1 (with bonus points if you go with <prefix>_<verb>_<noun>
> > > for the two identified cases)
> >
> > I for one think we should try to keep the names of something that
> > (hopefully) will be used often as short possible to reduce the likely
> > hood of typos.
> >
> > Ilia Alshanetsky
> 
> Agreed. input_id_filter() is shorter than input_name_to_filter(), and
> input_list_filters() is the same length as input_filters_list().

This function won't be used a lot, so a longer name is fine. I would go 
for input_get_filter_id() and input_list_filters().

regards,
Derick