Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25762 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 25034 invoked by uid 1010); 18 Sep 2006 18:16:35 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 25019 invoked from network); 18 Sep 2006 18:16:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Sep 2006 18:16:35 -0000 Authentication-Results: pb1.pair.com header.from=nlopess@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=nlopess@php.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain php.net from 212.55.154.21 cause and error) X-PHP-List-Original-Sender: nlopess@php.net X-Host-Fingerprint: 212.55.154.21 relay1.ptmail.sapo.pt Linux 2.4/2.6 Received: from [212.55.154.21] ([212.55.154.21:41144] helo=sapo.pt) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A4/53-31601-F72EE054 for ; Mon, 18 Sep 2006 14:16:33 -0400 Received: (qmail 10002 invoked from network); 18 Sep 2006 18:16:27 -0000 Received: from unknown (HELO sapo.pt) (10.134.35.154) by relay1 with SMTP; 18 Sep 2006 18:16:27 -0000 Received: (qmail 6141 invoked from network); 18 Sep 2006 18:16:27 -0000 X-AntiVirus: PTMail-AV 0.3-0.88.4 X-Virus-Status: Clean (0.00840 seconds) Received: from unknown (HELO pc07653) (nunoplopes@sapo.pt@[82.155.79.240]) (envelope-sender ) by mta4 (qmail-ldap-1.03) with SMTP for ; 18 Sep 2006 18:16:27 -0000 Message-ID: <017001c6db4e$8ef794c0$0100a8c0@pc07653> To: "Ilia Alshanetsky" Cc: "PHPdev" References: <005701c6d984$49c64980$0100a8c0@pc07653> <006c01c6da51$3a51bfc0$0100a8c0@pc07653> <786943AB-4850-4129-B60A-43128C9E6586@prohost.org> Date: Mon, 18 Sep 2006 19:16:27 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2869 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2962 Subject: Re: [PHP-DEV] leaks related with virtual_file_ex() From: nlopess@php.net ("Nuno Lopes") > On 17-Sep-06, at 8:03 AM, Nuno Lopes wrote: > >> OK, first patch to fix the 'tests/lang/bug35176.phpt' specific problem: >> http://mega.ist.utl.pt/~ncpl/zend_include_memleak.txt >> There might be other issues with virtual_file_ex() that I haven't fully >> tested. > > Can you not simply add the free before the zend_message_dispatcher > (ZMSG_FAILED_REQUIRE_FOPEN, Z_STRVAL_P(inc_filename)); line which is > followed by a fatal error and in all other instances rely on the existing > free() ? > > Ilia Alshanetsky well it depends of the zend api.. If you consider that that error message will be fatal and the include one won't be, well, your solution is simpler, otherwise it needs the bigger patch. Anyway, I agree with you (whoever uses zend engine without PHP will have to have that in attention). Nuno