Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25749 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4706 invoked by uid 1010); 18 Sep 2006 02:51:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 4691 invoked from network); 18 Sep 2006 02:51:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Sep 2006 02:51:50 -0000 Authentication-Results: pb1.pair.com header.from=iliaal@gmail.com; sender-id=pass; domainkeys=good Authentication-Results: pb1.pair.com smtp.mail=iliaal@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.162.201 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: iliaal@gmail.com X-Host-Fingerprint: 64.233.162.201 nz-out-0102.google.com Linux 2.4/2.6 Received: from [64.233.162.201] ([64.233.162.201:47967] helo=nz-out-0102.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F4/17-44769-2C90E054 for ; Sun, 17 Sep 2006 22:51:47 -0400 Received: by nz-out-0102.google.com with SMTP id 8so335150nzo for ; Sun, 17 Sep 2006 19:51:44 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:x-priority:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=oSdOrwy0nJatvukBaQfxzDlWbmDVNa6MWRToDO1ga05Mq6MDZ+C/q3oLCah9J/Qodb/LycvOT59liutWrYPuTfn7RlGhzAdrx8QyXx4hpgGJ7Ays9McCGgWSKnYlBm/S+Q41/HMn+jChgskBpbafd5hlct4+k6pBcS/EbfERuL4= Received: by 10.65.119.14 with SMTP id w14mr14842510qbm; Sun, 17 Sep 2006 19:51:44 -0700 (PDT) Received: from ?192.168.1.6? ( [72.59.8.142]) by mx.gmail.com with ESMTP id f13sm7526565qba.2006.09.17.19.51.43; Sun, 17 Sep 2006 19:51:43 -0700 (PDT) In-Reply-To: <006c01c6da51$3a51bfc0$0100a8c0@pc07653> References: <005701c6d984$49c64980$0100a8c0@pc07653> <006c01c6da51$3a51bfc0$0100a8c0@pc07653> Mime-Version: 1.0 (Apple Message framework v752.2) X-Priority: 3 Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: <786943AB-4850-4129-B60A-43128C9E6586@prohost.org> Cc: "PHPdev" Content-Transfer-Encoding: 7bit Date: Sun, 17 Sep 2006 22:51:25 -0400 To: Nuno Lopes X-Mailer: Apple Mail (2.752.2) Sender: Ilia Alshanetsky Subject: Re: [PHP-DEV] leaks related with virtual_file_ex() From: ilia@prohost.org (Ilia Alshanetsky) On 17-Sep-06, at 8:03 AM, Nuno Lopes wrote: > OK, first patch to fix the 'tests/lang/bug35176.phpt' specific > problem: http://mega.ist.utl.pt/~ncpl/zend_include_memleak.txt > There might be other issues with virtual_file_ex() that I haven't > fully tested. Can you not simply add the free before the zend_message_dispatcher (ZMSG_FAILED_REQUIRE_FOPEN, Z_STRVAL_P(inc_filename)); line which is followed by a fatal error and in all other instances rely on the existing free() ? Ilia Alshanetsky