Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25739
Return-Path: <pierre.php@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 15058 invoked by uid 1010); 16 Sep 2006 17:46:16 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 15043 invoked from network); 16 Sep 2006 17:46:16 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 16 Sep 2006 17:46:16 -0000
Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=good
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.188 as permitted sender)
DomainKey-Status: good
X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01
X-PHP-List-Original-Sender: pierre.php@gmail.com
X-Host-Fingerprint: 64.233.182.188 nf-out-0910.google.com Linux 2.4/2.6
Received: from [64.233.182.188] ([64.233.182.188:22836] helo=nf-out-0910.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 54/F0-23155-8683C054 for <internals@lists.php.net>; Sat, 16 Sep 2006 13:46:16 -0400
Received: by nf-out-0910.google.com with SMTP id y25so2900575nfb
        for <internals@lists.php.net>; Sat, 16 Sep 2006 10:46:13 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=g6XEpNo5B5V2rlFBdTPd3jN4XZshOaDrQbdPjMSL4cW4BURu791wPUoAzPo/SSEsEVg/bNMrIcpjxTN7lCsA8EhQ9dtN3MARwl0qHfdqtqFNAzsxACOZm9vQckLV3+oGCSUQ8EaD4ab/IAwBYVK+TohaOKuHOhnj53hDh9MpNe8=
Received: by 10.78.196.10 with SMTP id t10mr2477926huf;
        Sat, 16 Sep 2006 10:46:13 -0700 (PDT)
Received: by 10.78.137.6 with HTTP; Sat, 16 Sep 2006 10:46:13 -0700 (PDT)
Message-ID: <fe05d1540609161046r97d0070ucc957a2c367f025e@mail.gmail.com>
Date: Sat, 16 Sep 2006 19:46:13 +0200
To: "Dan Scott" <denials@gmail.com>
Cc: "Ilia Alshanetsky" <ilia@prohost.org>, internals@lists.php.net, 
	derick@php.net, rasmus@php.net
In-Reply-To: <fbb0d11d0609161028p207341b5mc2444e7b83ab19c@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20060916125431.42e9a5dd@pierre-u64>
	 <fbb0d11d0609160835u1cef678awbdcf99736b16513d@mail.gmail.com>
	 <94DEA960-10E5-4796-8570-BB66520FC27C@prohost.org>
	 <fbb0d11d0609161028p207341b5mc2444e7b83ab19c@mail.gmail.com>
Subject: Re: [PHP-DEV] ext/filter, Final API proposal
From: pierre.php@gmail.com (Pierre)

Hello,

On 9/16/06, Dan Scott <denials@gmail.com> wrote:
> On 16/09/06, Ilia Alshanetsky <ilia@prohost.org> wrote:
> >
> > On 16-Sep-06, at 11:35 AM, Dan Scott wrote:
> >
> > > Minor: the general structure of the function names are
> > > <prefix>_<verb>_<noun>, so it would be more consistent if this was
> > > 'input_list_filters'.
> > >
> > > Overall: +1 (with bonus points if you go with <prefix>_<verb>_<noun>
> > > for the two identified cases)
> >
> > I for one think we should try to keep the names of something that
> > (hopefully) will be used often as short possible to reduce the likely
> > hood of typos.
> >
> > Ilia Alshanetsky
>
> Agreed. input_id_filter() is shorter than input_name_to_filter(), and
> input_list_filters() is the same length as input_filters_list().

It should be something_to_something, not something_something. "is it
id_to_filter or id_filter?", no, I'm not going to ask me this question
in the next few years.

Also it is not a ID but its name, its ID is internal, numeric and
defined by a constant. name_to_filter reflects this fact, we can use
name_to_id if you prefer, but not id_to_filter.
However, that's nitpicking, you will use this function once a month
for debugging/testing/abstraction purposes.

input_filters_list or input_list_filters, I don't care, please choose one :)

--Pierre