Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25510 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 49067 invoked by uid 1010); 2 Sep 2006 19:15:55 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 49051 invoked from network); 2 Sep 2006 19:15:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Sep 2006 19:15:55 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 212.227.48.61 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 212.227.48.61 mayflowerholding.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.227.48.61] ([212.227.48.61:46541] helo=s15175637.rootmaster.info) by pb1.pair.com (ecelerity 2.1.1.8 r(12602M)) with ESMTP id E9/31-23420-868D9F44 for ; Sat, 02 Sep 2006 15:15:54 -0400 Received: (qmail 16738 invoked by uid 2520); 2 Sep 2006 21:15:50 +0200 Received: from 62.245.160.34 by s15175637 (envelope-from , uid 2020) with qmail-scanner-1.25st (uvscan: v4.4.00/v4843. spamassassin: 3.1.4. perlscan: 1.25st. Clear:RC:0(62.245.160.34):SA:0(0.5/5.0):. Processed in 2.33096 secs); 02 Sep 2006 19:15:50 -0000 X-Spam-Status: No, hits=0.5 required=5.0 Received: from ppp-62-245-160-34.dynamic.mnet-online.de (HELO ?192.168.1.104?) (62.245.160.34) by mayflowerholding.com with SMTP; 2 Sep 2006 21:15:47 +0200 Message-ID: <44F9D846.2080809@schlueters.de> Date: Sat, 02 Sep 2006 21:15:18 +0200 User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Steph Fox CC: internals References: <016501c6ce9c$116e2910$6602a8c0@foxbox> In-Reply-To: <016501c6ce9c$116e2910$6602a8c0@foxbox> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] make Reflection options work on CLI/win32 From: johannes@schlueters.de (Johannes Schlueter) Hi Steph, thanks for the patch, I've just committed it to the active branches. btw. Marcus rewrote most parts of the implementation. (credits to whom they belong *g*) johannes Steph Fox wrote: > Folk with karma, hi - > > None of Johannes' CLI Reflection options work under doze in PHP 5.2.0 > RC 3 > > C:\sandbox\php5\Release_TS>php --rc DateTime > Could not open input file: DateTime > > The attached trivial patch defines HAVE_REFLECTION to rectify that. > The define's also missing from PHP_5_1 branch and CVS HEAD. > > - Steph --- config.w32.old Sat Sep 02 03:43:40 2006 > +++ config.w32 Sat Sep 02 03:43:18 2006 > @@ -5,4 +5,5 @@ > > if (PHP_REFLECTION != "no") { > EXTENSION("reflection", "php_reflection.c"); > + AC_DEFINE('HAVE_REFLECTION', 1, 'Reflection support enabled'); > } >