Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25356 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62017 invoked by uid 1010); 14 Aug 2006 23:38:59 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 62002 invoked from network); 14 Aug 2006 23:38:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Aug 2006 23:38:59 -0000 X-PHP-List-Original-Sender: ceo@l-i-e.com X-Host-Fingerprint: 67.139.134.202 o2.hostbaby.com FreeBSD 4.7-5.2 (or MacOS X 10.2-10.3) (2) Received: from ([67.139.134.202:2802] helo=o2.hostbaby.com) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id CD/38-19138-29901E44 for ; Mon, 14 Aug 2006 19:38:59 -0400 Received: (qmail 6974 invoked by uid 98); 14 Aug 2006 23:39:01 -0000 Received: from 127.0.0.1 by o2.hostbaby.com (envelope-from , uid 1013) with qmail-scanner-1.25 ( Clear:RC:1(127.0.0.1):. Processed in 0.097211 secs); 14 Aug 2006 23:39:01 -0000 X-Qmail-Scanner-Mail-From: ceo@l-i-e.com via o2.hostbaby.com X-Qmail-Scanner: 1.25 (Clear:RC:1(127.0.0.1):. Processed in 0.097211 secs) Received: from unknown (HELO l-i-e.com) (127.0.0.1) by localhost with SMTP; 14 Aug 2006 23:39:00 -0000 Received: from 67.108.68.40 (SquirrelMail authenticated user ceo@l-i-e.com) by www.l-i-e.com with HTTP; Mon, 14 Aug 2006 18:39:00 -0500 (CDT) Message-ID: <35405.67.108.68.40.1155598740.squirrel@www.l-i-e.com> In-Reply-To: References: <005301c6bec7$783e5c80$0201a8c0@pc1> <006d01c6bedd$c86c7a00$0201a8c0@pc1> Date: Mon, 14 Aug 2006 18:39:00 -0500 (CDT) To: "Pierre" Cc: "Matt W" , internals@lists.php.net Reply-To: ceo@l-i-e.com User-Agent: Hostbaby Webmail MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Subject: Re: [PHP-DEV] [PATCH] array_count_values bug: mishandling of numbers with leading whitespace From: ceo@l-i-e.com ("Richard Lynch") On Sun, August 13, 2006 9:15 am, Pierre wrote: > On 8/13/06, Matt W wrote: > >> Not reasonable or safe? Then why were the other bugs fixed instead >> of being >> marked "Bogus" if array_count_values() was *supposed* to behave >> differently >> in 5? > > Safe as it will not break working php5 code. Changing this behavior > now can break many things out there (for php 5 users, php4 users are > out of my worries for this problem). What I mean is that we should > first check the impact and see why this change has been done (I > remember something like a valid reason, but did not get the time to > verify). > > In short, it is just what I said in the previous discussion, such > changes must be done carefully and with a huge amount of test cases > (and stick to them). I'm not choosing one solution or another, only > saying that the decision should be taken carefully and generally. While I agree the change should be carefully reviewed, I must wonder why the millions upon millions of lines of code in 4.x are going to be ignored here... What rationale is there for breaking the BC? Obviously you think it should be broken -- I just don't understand why... -- Like Music? http://l-i-e.com/artists.htm