Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25350 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36389 invoked by uid 1010); 14 Aug 2006 19:25:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 36374 invoked from network); 14 Aug 2006 19:25:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Aug 2006 19:25:50 -0000 X-PHP-List-Original-Sender: frank@kromann.info X-Host-Fingerprint: 64.186.239.125 c-064-186-239-125.oc1.redwire.net Linux 2.5 (sometimes 2.4) (4) Received: from ([64.186.239.125:56240] helo=mail.kromann.info) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id FF/AA-19138-C3EC0E44 for ; Mon, 14 Aug 2006 15:25:49 -0400 Received: by mail.kromann.info (Postfix, from userid 510) id B86034040CA; Mon, 14 Aug 2006 12:25:00 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on mail.kromann.info X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.1 Received: from warp (www.kromann.info [64.186.239.115]) by mail.kromann.info (Postfix) with SMTP id EE8624040C6; Mon, 14 Aug 2006 12:24:59 -0700 (PDT) To: runner60 Cc: X-Mailer: Swwwing 2000 Message-ID: <11555835353960000@9866357972520000.9866341568840000> MIME-Version: 1.0 Reply-To: "Frank M. Kromann" Date: Mon, 14 Aug 2006 12:25:35 -0700 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] config.w32 quirk From: frank@kromann.info ("Frank M. Kromann") That has to do with the way the config.w32 files are processed. changing one line in win32\build\buildconf.js from re = new RegExp("(ARG_(ENABLE|WITH)\([^;]+\);)", "gm"); to re = new RegExp("^(ARG_(ENABLE|WITH)\([^;]+\);)", "gm"); will prevent this from happening. This change will require the ARG_ to start a the begining of the line. Unless there are any reasons not to do this, I'll commit the patch. - Frank > I had this in a config.w32 file: > > ARG_ENABLE("winbinder", "winbinder support", "no"); > //ARG_WITH("winbinder", "winbinder support", "no"); > > line 2 is not treated as comment and after buildconf > cscript configure.js --help > both --enable-winbinder and --with-winbinder > were listed as availabe options. > > Don't know if this is a bug. > > Davide. > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >