Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25339 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26141 invoked by uid 1010); 13 Aug 2006 14:15:27 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 26126 invoked from network); 13 Aug 2006 14:15:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Aug 2006 14:15:26 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; domainkeys=good DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 66.249.92.170 ug-out-1314.google.com Linux 2.4/2.6 Received: from ([66.249.92.170:29541] helo=ug-out-1314.google.com) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id 82/A2-19138-8F33FD44 for ; Sun, 13 Aug 2006 10:15:26 -0400 Received: by ug-out-1314.google.com with SMTP id k3so1328591ugf for ; Sun, 13 Aug 2006 07:15:18 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=X6U2ynkjTtE2K2xFl0HOTfXXBdmMFYhnXnyCkOa1i8Wg8eDiLaXkCZ7gbmlnVbj9C8EKQ+3vCm01P/JPrdH7zJQzzqxxM+Vg7GZSNUW4SSOxw/jAbhCNQIuiE2kyLLAGRwx3bRLd7wm1OQfM3QjcrKV9bnAY9F+ouLLYJQYtIxg= Received: by 10.67.101.8 with SMTP id d8mr6833927ugm; Sun, 13 Aug 2006 07:15:18 -0700 (PDT) Received: by 10.66.248.15 with HTTP; Sun, 13 Aug 2006 07:15:18 -0700 (PDT) Message-ID: Date: Sun, 13 Aug 2006 16:15:18 +0200 To: "Matt W" Cc: internals@lists.php.net In-Reply-To: <006d01c6bedd$c86c7a00$0201a8c0@pc1> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <005301c6bec7$783e5c80$0201a8c0@pc1> <006d01c6bedd$c86c7a00$0201a8c0@pc1> Subject: Re: [PHP-DEV] [PATCH] array_count_values bug: mishandling of numbers with leading whitespace From: pierre.php@gmail.com (Pierre) Hi, On 8/13/06, Matt W wrote: > Not reasonable or safe? Then why were the other bugs fixed instead of being > marked "Bogus" if array_count_values() was *supposed* to behave differently > in 5? Safe as it will not break working php5 code. Changing this behavior now can break many things out there (for php 5 users, php4 users are out of my worries for this problem). What I mean is that we should first check the impact and see why this change has been done (I remember something like a valid reason, but did not get the time to verify). In short, it is just what I said in the previous discussion, such changes must be done carefully and with a huge amount of test cases (and stick to them). I'm not choosing one solution or another, only saying that the decision should be taken carefully and generally. --Pierre