Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:25278 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 1632 invoked by uid 1010); 10 Aug 2006 10:40:12 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 1617 invoked from network); 10 Aug 2006 10:40:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Aug 2006 10:40:12 -0000 Authentication-Results: pb1.pair.com header.from=manchokapitancho@gmail.com; domainkeys=good DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: manchokapitancho@gmail.com X-Host-Fingerprint: 72.14.204.226 qb-out-0506.google.com Linux 2.4/2.6 Received: from ([72.14.204.226:51517] helo=qb-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id 6A/F6-08715-90D0BD44 for ; Thu, 10 Aug 2006 06:40:10 -0400 Received: by qb-out-0506.google.com with SMTP id o24so105669qba for ; Thu, 10 Aug 2006 03:40:07 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=qPEyTa+JM6se5WfGa6iVhB5aWZKODT+f0cFQVv1Dm29vYlb7uHVnL7gqejyBdFur2GjIz+6NOzRFZc74jF6u4F3v1U6uhsPFEFQFOOf3a4m8pgrDDwYuPiR/+eNmd16mbAOOPXacBuhAcIx/9b4VOyESsAlPZL8Bf8bUV5KLXzE= Received: by 10.78.193.19 with SMTP id q19mr1168370huf; Thu, 10 Aug 2006 03:40:05 -0700 (PDT) Received: by 10.78.169.10 with HTTP; Thu, 10 Aug 2006 03:40:05 -0700 (PDT) Message-ID: Date: Thu, 10 Aug 2006 13:40:05 +0300 To: internals@lists.php.net In-Reply-To: <49.E4.30310.F2CC9D44@pb1.pair.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_69990_19155996.1155206405558" References: <49.E4.30310.F2CC9D44@pb1.pair.com> Subject: Re: [PHP-DEV] PDO statement execute enhancement From: manchokapitancho@gmail.com ("Marian Kostadinov") ------=_Part_69990_19155996.1155206405558 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline This code here http://lxr.php.net/source/php-src/ext/pdo/pdo_stmt.c#301 is maybe the point where a solution can be provided checking for param ->paramno == -1 is enough to detect an incorrect parameter and silently ignore it or emit a notice. 2006/8/9, Lukas Smith : > > Marian Kostadinov wrote: > > > Yes, that's my idea - to ignore keys that are not defined as > placeholder. > > And not only for objects but for arrays also. > > I do not know the implementation in PDO, but the implementation I made > in MDB2 only tries to parse the placeholders if it has to emulate or > detects that a placeholder type is used that needs to be rewritten for > the given RDBMS. If PDO has a similar implementation it would mean now > that PDO always has to parse the entire query to determine which keys to > ignore. I feel this is suboptimal and therefore I would be opposed to > this change. > > regards, > Lukas > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > ------=_Part_69990_19155996.1155206405558--