Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25072
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <001501c6b47f$7ee8f380$0201a8c0@pc1>
To: <internals@lists.php.net>
Date: Mon, 31 Jul 2006 03:58:30 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: zend_u_strtod is slow - possible fix
From: php_lists@realplain.com ("Matt W")

Hi all,

As I was working on upgrading the dec[bin|hex|oct] functions to convert
large doubles, I noticed how much slower things were when converting Unicode
strings to double.  I found that converting the whole thing to string and
using regular zend_strtod() was much faster.  Then I decided to try
modifying the u_strtod() function to do the same, but just on the relevant
numeric portion.

I don't know if I did everything right, but it seems to work fine with my
limited testing.  (I was working from zend_u_strtol() and
zval_unicode_to_string_ex(). :-))  The function is now about *8 times*
faster, and nearly 20 times faster on a non-numeric string!  (I'm on
Windows.)

diff: http://realplain.com/php/zend_u_strtod.diff

Is this something that can be used?


Thanks,
Matt