Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:25022
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <001b01c6b1ca$c840adf0$0100a8c0@pc07653>
To: "Andrei Zmievski" <andrei@gravitonic.com>
Cc: <internals@lists.php.net>,
	"Michael Wallner" <mike@php.net>
References: <006501c6b036$2f6f3e60$0100a8c0@pc07653> <29.B7.04178.B7D96C44@pb1.pair.com> <009401c6b19b$80fe8950$0100a8c0@pc07653> <72D417E5-2BC4-48DF-82F3-BEA9CA48C08D@gravitonic.com>
Date: Thu, 27 Jul 2006 23:19:52 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: upgrading the zlib extension to unicode
From: nlopess@php.net ("Nuno Lopes")

Yep. After thoughting about it, I think it is the best way. If the user 
wants to save the unicode directly (and save BOM, etc), he has functions to 
handle that.
So, I've just changed the 's' parameters to 'S' (binary only). I left the 
ob_start handler for Mike since he said he wanted to help with that. The 
filter code was already upgraded (probably by Sara).

Nuno


----- Original Message ----- 
> So you decide to make the user pass in a binary string explicitly. I 
> suppose that's an approach since it makes them think about what  format 
> the binary string should be in before it's compressed.
>
> -Andrei
>
>
> On Jul 27, 2006, at 9:41 AM, Nuno Lopes wrote:
>
>>> Nuno Lopes wrote:
>>>> Hello,
>>>>
>>>> So Andrei asked me to upgrade the zlib extension, but I have a  few 
>>>> questions I would like to discuss with you:
>>>
>>> I'd like to collaborate on this.  Besides reimplementing the output
>>> handler to use the new API, I planned to upgrade it to something 
>>> similar like http_encoding_api.
>>
>> OK, I think I've completed the upgrade (it now requires a binary 
>> string), but I left the ob_gzhandler() function for you ;)
>>
>> Nuno