Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24982 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 47458 invoked by uid 1010); 26 Jul 2006 12:02:42 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 47443 invoked from network); 26 Jul 2006 12:02:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Jul 2006 12:02:42 -0000 Authentication-Results: pb1.pair.com header.from=rquadling@googlemail.com; domainkeys=good DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: rquadling@googlemail.com X-Host-Fingerprint: 64.233.166.179 py-out-1112.google.com Linux 2.4/2.6 Received: from ([64.233.166.179:57913] helo=py-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id 97/C0-04178-0E957C44 for ; Wed, 26 Jul 2006 08:02:41 -0400 Received: by py-out-1112.google.com with SMTP id x31so681193pye for ; Wed, 26 Jul 2006 05:02:38 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=googlemail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=m917MSYVRXxFudvzX8q7QabyD6J5X9s4cLL7yYsk4K2cq5YIeXshkHDDwzueRhpbJslLW3wQSDlA4mvDP5OfdLHYdRqRljHTBS22idlMwWV/EW5sB/jv5nrjmUbcBMKdLHkRv57EZIdwYAO6MMeIeEJii0m/2IsVlCKbp4G8fKI= Received: by 10.35.18.4 with SMTP id v4mr11165708pyi; Wed, 26 Jul 2006 05:02:38 -0700 (PDT) Received: by 10.35.93.18 with HTTP; Wed, 26 Jul 2006 05:02:37 -0700 (PDT) Message-ID: <10845a340607260502w65472ab1m2aab43a0a67a265b@mail.gmail.com> Date: Wed, 26 Jul 2006 13:02:37 +0100 Reply-To: RQuadling@GoogleMail.com To: "Andrei Zmievski" Cc: "Matt W" , internals@lists.php.net, toggg@php.net In-Reply-To: <048F023B-F78A-45C4-8C9D-BAB1303F5780@gravitonic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <014e01c6acbe$680b1bc0$0201a8c0@pc1> <10845a340607210543lfe173abq2221a1c833c5d9e1@mail.gmail.com> <017701c6acc6$3a526be0$0201a8c0@pc1> <00d401c6ad61$9d235810$0201a8c0@pc1> <44C4626D.5030108@php.net> <00ac01c6aef6$2adc0d10$0201a8c0@pc1> <048F023B-F78A-45C4-8C9D-BAB1303F5780@gravitonic.com> Subject: Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe From: rquadling@googlemail.com ("Richard Quadling") Is the patch to use the _ex functions needed? On 24/07/06, Andrei Zmievski wrote: > Fixed now. > > -Andrei > > > On Jul 24, 2006, at 12:52 AM, Matt W wrote: > > > Hi, > > > > ----- Original Message ----- > > From: "bertrand Gugger" > > Sent: Monday, July 24, 2006 > > > > > >> Matt W wrote: > >>> Hi Andrei, > >>> > >>> I see you applied my patch. > >> Testing with a php5.2-200607222030 snaps having > >> /* $Id: array.c,v 1.308.2.21.2.7 2006/07/22 16:58:39 andrei Exp $ */ > >> > >> Looks by me as the ext/standard/tests/array/array_combine.phpt fails > >> Is it by me ? > >> > >> $ diff -W 60 -y --suppress-common-lines > >> ext/standard/tests/array/array_combine.exp > >> ext/standard/tests/array/array_combine.out > >> [green] => green | [gree] => green > >> [red] => red | [re] => red > >> [yellow] => yellow | [yello] => yellow > >> [green] => 1 | [gree] => 1 > >> [red] => 2 | [re] => 2 > >> [yellow] => 3 | [yello] => 3 > >> [green] => 0 | [gree] => 0 > >> [red] => 1 | [re] => 1 > >> [yellow] => 2 | [yello] => 2 > >> [green] => 1 | [gree] => 1 > >> [red] => | [re] => > >> [yellow] => | [yello] => > >> [1] => green | [] => green > >> [2] => red | [] => red > >> [3] => yellow | [] => yellow > >> [1] => 1 | [] => 1 > >> [2] => 2 | [] => 2 > >> [3] => 3 | [] => 3 > >> [1] => 0 | [] => 0 > >> [2] => 1 | [] => 1 > >> [3] => 2 | [] => 2 > >> [1] => 1 | [] => 1 > >> [2] => | [] => > >> [3] => | [] => > >> > >> PHP : /home/bertrand/php/php5.2-200607222030/sapi/cli/php > >> PHP_SAPI : cli > >> PHP_VERSION : 5.2.0-dev > >> ZEND_VERSION: 2.2.0 > >> PHP_OS : Linux - Linux ancilla.toggg.net 2.6.12-1.1381_FC3 #1 > >> Fri > >> Oct 21 03 :46:55 EDT 2005 i686 > >> > >> Configure Command => './configure' > >> > >> Sorry for the noise , case I did something wrong , but what ? > >> (or case it is repaired in the mean time) > > > > Nope, it's broken. :-) I was confused as to why Andrei only fully > > applied > > my patch for HEAD, and seemed to manually "take part of" the 5.2 > > patch (I > > thought the binary key change was unwanted in 5.2, but he did > > update it > > then). Now it needs a 4th update... *shrug* :-) > > > > Andrei, in the first add_assoc_zval_ex(), after Z_STRLEN_PP > > (entry_keys), you > > forgot the +1. > > > >> -- > >> toggg > > > > It wasn't your fault, good catch. ;-) > > > > > > Matt > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- ----- Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 "Standing on the shoulders of some very clever giants!"