Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24918 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27903 invoked by uid 1010); 24 Jul 2006 05:57:42 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 27888 invoked from network); 24 Jul 2006 05:57:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jul 2006 05:57:42 -0000 X-PHP-List-Original-Sender: toggg@php.net X-Host-Fingerprint: 212.27.42.29 smtp3-g19.free.fr Linux 2.4/2.6 Received: from ([212.27.42.29:51189] helo=smtp3-g19.free.fr) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id 61/D2-04178-45164C44 for ; Mon, 24 Jul 2006 01:57:42 -0400 Received: from [192.168.0.3] (lns-bzn-24-82-64-152-182.adsl.proxad.net [82.64.152.182]) by smtp3-g19.free.fr (Postfix) with ESMTP id 8F09B430BE; Mon, 24 Jul 2006 07:57:37 +0200 (CEST) Message-ID: <44C4626D.5030108@php.net> Date: Mon, 24 Jul 2006 08:02:21 +0200 Reply-To: toggg@php.net User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc3 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Matt W CC: internals@lists.php.net, Andrei Zmievski References: <014e01c6acbe$680b1bc0$0201a8c0@pc1> <10845a340607210543lfe173abq2221a1c833c5d9e1@mail.gmail.com> <017701c6acc6$3a526be0$0201a8c0@pc1> <00d401c6ad61$9d235810$0201a8c0@pc1> In-Reply-To: <00d401c6ad61$9d235810$0201a8c0@pc1> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe From: toggg@php.net (bertrand Gugger) Matt W wrote: > Hi Andrei, > > I see you applied my patch. Testing with a php5.2-200607222030 snaps having /* $Id: array.c,v 1.308.2.21.2.7 2006/07/22 16:58:39 andrei Exp $ */ Looks by me as the ext/standard/tests/array/array_combine.phpt fails Is it by me ? $ diff -W 60 -y --suppress-common-lines ext/standard/tests/array/array_combine.exp ext/standard/tests/array/array_combine.out [green] => green | [gree] => green [red] => red | [re] => red [yellow] => yellow | [yello] => yellow [green] => 1 | [gree] => 1 [red] => 2 | [re] => 2 [yellow] => 3 | [yello] => 3 [green] => 0 | [gree] => 0 [red] => 1 | [re] => 1 [yellow] => 2 | [yello] => 2 [green] => 1 | [gree] => 1 [red] => | [re] => [yellow] => | [yello] => [1] => green | [] => green [2] => red | [] => red [3] => yellow | [] => yellow [1] => 1 | [] => 1 [2] => 2 | [] => 2 [3] => 3 | [] => 3 [1] => 0 | [] => 0 [2] => 1 | [] => 1 [3] => 2 | [] => 2 [1] => 1 | [] => 1 [2] => | [] => [3] => | [] => PHP : /home/bertrand/php/php5.2-200607222030/sapi/cli/php PHP_SAPI : cli PHP_VERSION : 5.2.0-dev ZEND_VERSION: 2.2.0 PHP_OS : Linux - Linux ancilla.toggg.net 2.6.12-1.1381_FC3 #1 Fri Oct 21 03 :46:55 EDT 2005 i686 Configure Command => './configure' Sorry for the noise , case I did something wrong , but what ? (or case it is repaired in the mean time) -- toggg