Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:24897
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <009301c6ae39$a6514270$0201a8c0@pc1>
To: <internals@lists.php.net>, <RQuadling@GoogleMail.com>
Cc: "Andrei Zmievski" <andrei@gravitonic.com>
References: <014e01c6acbe$680b1bc0$0201a8c0@pc1> <10845a340607210543lfe173abq2221a1c833c5d9e1@mail.gmail.com> <017701c6acc6$3a526be0$0201a8c0@pc1> <FAE13B7E-4AA9-40C3-8907-90FA5A619B95@gravitonic.com> <00d401c6ad61$9d235810$0201a8c0@pc1> <10845a340607221404u4f515bb9w914d4a61f9345f28@mail.gmail.com> <10845a340607221454h1c8923bcg9ca534b21853bd86@mail.gmail.com> <002901c6ae0a$70316870$0201a8c0@pc1>
Date: Sun, 23 Jul 2006 04:23:24 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Optimizing add_assoc_* with static keys (WAS: Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe)
From: php_lists@realplain.com ("Matt W")

Hi Richard, Andrei,

Hold on about a patch to optimize add_assoc_* and hard-coded keys.  I just
finished some testing to see what difference it makes: none! :-)  Compilers
must optimize strlen("static string") to the literal value; at least VC++
Express does.  Using a dynamic string from estrdup(), *_ex with the
hard-coded length was about 10% faster with a 12 character key on my old
system (dual 930MHz).  But again, no difference with static ones like in
PHP's code.  It was an optimization though in array_combine(), being dynamic
key values.

So, nothin' to worry about here... :-)


Matt


----- Original Message -----
From: "Matt W"
Sent: Saturday, July 22, 2006


> Hi Richard,
>
> Replacement script made it pretty simple I guess. :-)  But sizeof("key")+1
> should just be sizeof("key") (which == strlen("key")+1).
>
> Are there any uses of add_u_assoc_* with hard-coded keys?
>
> These changes make things look a little messy, you think?  The string is
in
> 2 places, etc...  (Maybe why it wasn't done in the first place?)  Seems
like
> that ZEND_STRS() macro you mentioned would work well.  Or maybe cleanest
> would be some new add_static_assoc_* macros (and _u versions if needed),
or
> some other naming convention, that uses sizeof() instead of strlen()+1.
>
> What do the main devs think?
>
>
> Matt