Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:24891
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <44C2B2E3.101@php.net>
Date: Sun, 23 Jul 2006 01:21:07 +0200
Reply-To:  toggg@php.net
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc3 (X11/20050929)
MIME-Version: 1.0
To: Matt W <php_lists@realplain.com>
CC:  internals@lists.php.net
References: <007001c6ab21$b8d560e0$0201a8c0@pc1> <00fb01c6ad81$f3b61260$0201a8c0@pc1>
In-Reply-To: <00fb01c6ad81$f3b61260$0201a8c0@pc1>
Content-Type: multipart/mixed;
 boundary="------------090803030203070104010304"
Subject: Re: [PHP-DEV] [PATCH] number_format enhancements
From: toggg@php.net (bertrand Gugger)

--------------090803030203070104010304
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Matt W wrote:
> Hi,
> 
> Haven't heard any opinions on these functionality changes...  (Though I know
> more significant things keep you busy!)
> 
> Do many other people use number_format()??  Wouldn't allowing thousands
> separator as param #2 simplify things?
> 
> Any issues with the semantics of operation?  Negative precision to specify
> trailing zero removal seems fine at least, even though that's different than
> round()'s behavior.
> 
> I've now made some tests, including changes of course, in case you were just
> waiting for them?  Hope they're enough.
> 
> http://realplain.com/php/number_format.phpt
Sorry , I did not come better than the attached test
copies http://toggg.info/number_format.phpt & 
http://toggg.info/number_format.diff
(you don't need "\n")
I wonder why lines are fliping , I guess it's a diff effect

Let me know how I apply your patch , so I get it blank :)
-- 
toggg

--------------090803030203070104010304
Content-Type: text/plain;
 name="number_format.phpt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="number_format.phpt"

--TEST--
number_format() function
--FILE--
<?php
	echo
"Numeric string decimals
",
number_format(12345, '0'), "
",
number_format(1234.51005, '4'), "
",
"Custom decimal point and thousands separator
",
number_format(-12345, 1, ',', ' '), "
",
number_format(-1234.51005, 4, ',', ' '), "
",
"No decimal point
",
number_format(0.1234, 3, '', ','), "
",
number_format(12345678.9, 2, '', ','), "
",
"Big number
",
number_format(1e16, 8), "
",
"Many decimals
",
number_format(12345, 400), "
",
"Minimal decimals (no trailing zeros)
",
number_format(9.87654, -3), "
",
number_format(-12345, -20), "
",
number_format(1234.51005, -3, '.', ' '), "
",
"Thousands separator as second parameter
",
number_format(1234.5, ''), "
",
number_format(12345, ','), "
",
number_format(12345, ' '), "
",
number_format(9876543.33, '.'), "
";
?>
--EXPECT--
Numeric string decimals
12,345
1,234.5101
Custom decimal point and thousands separator
-12 345,0
-1 234,5101
No decimal point
0123
12,345,67890
Big number
10,000,000,000,000,000.00000000
Many decimals
12,345.0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
Minimal decimals (no trailing zeros)
9.877
-12,345
1 234.51
Thousands separator as second parameter
1235
12,345
12 345
9.876.543


--------------090803030203070104010304
Content-Type: text/plain;
 name="number_format.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="number_format.diff"

008+ 123
009+ 1,234,567,890
008- 0123
009- 12,345,67890
015+ 10
015- 9.877
017+ 1 235
017- 1 234.51
019+ 1,235
020+ 12,345
019- 1235
021- 12 345
022+ 9,876,543
022- 9.876.543
--------------090803030203070104010304--