Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24735 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67224 invoked by uid 1010); 20 Jul 2006 02:40:02 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 67209 invoked from network); 20 Jul 2006 02:40:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jul 2006 02:40:02 -0000 X-PHP-List-Original-Sender: rrichards@ctindustries.net X-Host-Fingerprint: 216.117.147.250 unknown Linux 2.4/2.6 Received: from ([216.117.147.250:38227] helo=ctindustries.net) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id B0/9F-29121-00DEEB44 for ; Wed, 19 Jul 2006 22:40:01 -0400 Received: from [127.0.0.1] (dsta-aa203.pivot.net [66.186.171.203]) (authenticated bits=0) by ctindustries.net (8.12.8/8.12.8) with ESMTP id k6K2cBPI000907; Wed, 19 Jul 2006 22:38:12 -0400 Message-ID: <44BEED65.2010306@ctindustries.net> Date: Wed, 19 Jul 2006 22:41:41 -0400 User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: "internals@lists.php.net" , Andrei Zmievski Content-Type: multipart/mixed; boundary="------------040702040001090600010607" X-Antivirus: avast! (VPS 0629-1, 07/19/2006), Outbound message X-Antivirus-Status: Clean X-Virus-Scanned: ClamAV 0.88.3/1607/Tue Jul 18 18:37:18 2006 on ctindustries.net X-Virus-Status: Clean Subject: run-tests and unicode From: rrichards@ctindustries.net (Rob Richards) --------------040702040001090600010607 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit I was having some problems testing in native mode when my ini file had unicode enabled. It appears that it must be explicitly disabled in the script with the passing -N flag (make ntest). Otherwise it is picking up the ini setting and running the tests in unicode mode. Patch is attached just in case I am missing something here about how ntest is supposed to work. This also changes the use of single quotes to double quotes in a couple calls so the script is processed correctly under windows. Dont think this change will affect any systems, but it is needed to allow unicode testing on windows once enabled. Rob --------------040702040001090600010607 Content-Type: text/plain; name="run-tests.php.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="run-tests.php.txt" Index: run-tests.php =================================================================== RCS file: /repository/php-src/run-tests.php,v retrieving revision 1.297 diff -u -r1.297 run-tests.php --- run-tests.php 17 Jul 2006 11:46:12 -0000 1.297 +++ run-tests.php 20 Jul 2006 02:15:38 -0000 @@ -179,9 +179,9 @@ settings2params($info_params); $php_info = `$php $pass_options $info_params $info_file`; @unlink($info_file); - define('TESTED_PHP_VERSION', `$php -r 'echo PHP_VERSION;'`); + define('TESTED_PHP_VERSION', `$php -r "echo PHP_VERSION;"`); - $unicode = `$php $pass_options $info_params -r 'echo ini_get("unicode.semantics");'`; + $unicode = `$php $pass_options $info_params -r "echo ini_get('unicode.semantics');"`; define('TESTED_UNICODE', strcasecmp($unicode,"on") == 0 || $unicode == 1); // load list of enabled extensions @@ -333,6 +333,7 @@ case 'N': $unicode_and_native = false; $unicode_testing = false; + $ini_overwrites[] = 'unicode.semantics=0'; break; case '--no-clean': $no_clean = true; --------------040702040001090600010607--