Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24716 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 148 invoked by uid 1010); 19 Jul 2006 19:16:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 130 invoked from network); 19 Jul 2006 19:16:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jul 2006 19:16:31 -0000 X-PHP-List-Original-Sender: rrichards@ctindustries.net X-Host-Fingerprint: 216.117.147.250 unknown Linux 2.4/2.6 Received: from ([216.117.147.250:37784] helo=ctindustries.net) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id 20/ED-10398-63C7EB44 for ; Wed, 19 Jul 2006 14:38:47 -0400 Received: from [127.0.0.1] (dsta-aa203.pivot.net [66.186.171.203]) (authenticated bits=0) by ctindustries.net (8.12.8/8.12.8) with ESMTP id k6JIalPI030320; Wed, 19 Jul 2006 14:36:48 -0400 Message-ID: <44BE7C90.9030302@ctindustries.net> Date: Wed, 19 Jul 2006 14:40:16 -0400 User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: Andrei Zmievski CC: "internals@lists.php.net" References: <44BC07B0.3070505@ctindustries.net> <236712dad8ce4ce9e4c1b68726fc3d64@gravitonic.com> In-Reply-To: <236712dad8ce4ce9e4c1b68726fc3d64@gravitonic.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 0629-1, 07/19/2006), Outbound message X-Antivirus-Status: Clean X-Virus-Scanned: ClamAV 0.88.3/1607/Tue Jul 18 18:37:18 2006 on ctindustries.net X-Virus-Status: Clean Subject: Re: [PHP-DEV] unicode and xml extensions From: rrichards@ctindustries.net (Rob Richards) Andrei Zmievski wrote: > Rob, > > I have not tested the patch, but it looks good to me on cursory > overview. I assume it passes your tests? > The only comment I have is regarding the usage of 't' and 'T' > specifiers. Since you always have to pass binary UTF-8 strings to > libxml, we should always use 's' specifier and let PHP downconvert > Unicode strings based on the runtime encoding (which you set to UTF-8). Updated the code with your suggestion. I first attempted to eliminate having to change converters when running with unicode off for all the "t" parameters (save a few extra instructions there), but code is much more manageable now than converting them manually. Would like some feedback, though, on the changes made to xmlreader before moving on to any of the other extensions (seeing the changes are going to be pretty much the same). Rob