Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:24413
Return-Path: <helly@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 69774 invoked by uid 1010); 16 Jul 2006 09:25:14 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 69759 invoked from network); 16 Jul 2006 09:25:14 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 16 Jul 2006 09:25:14 -0000
X-PHP-List-Original-Sender: helly@php.net
X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6
Received: from ([81.169.182.136:39219] helo=strato.aixcept.de)
	by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP
	id 53/FD-11992-8410AB44 for <internals@lists.php.net>; Sun, 16 Jul 2006 05:05:13 -0400
Received: from baumbart.mbo (dslb-084-063-024-149.pools.arcor-ip.net [84.63.24.149])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by strato.aixcept.de (Postfix) with ESMTP id AC0D735C204;
	Sun, 16 Jul 2006 11:05:09 +0200 (CEST)
Date: Sun, 16 Jul 2006 11:05:14 +0200
Reply-To: Marcus Boerger <helly@php.net>
X-Priority: 3 (Normal)
Message-ID: <783701182.20060716110514@marcus-boerger.de>
To: Stanislav Malyshev <stas@zend.com>
Cc: Robert Cummings <robert@interjinn.com>, internals@lists.php.net
In-Reply-To: <Pine.LNX.4.64.0607161052370.3093@shire.zend.office>
References: <347185750.20060715202622@marcus-boerger.de> <20060715204801.4e02c985@pierre-u64> <56975.64.4.222.245.1153017351.squirrel@www.l-i-e.com> <1153018028.3177.4.camel@blobule> <Pine.LNX.4.64.0607161052370.3093@shire.zend.office>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: Long awaited line directive
From: helly@php.net (Marcus Boerger)

Hello Stanislav,

Sunday, July 16, 2006, 9:52:59 AM, you wrote:

RC>>>will tell them in what included template source file and on what line 
RC>>>they screwed up rather than them seeing an error that has no obvious 
RC>>>relationship whatsoever to what they did (did I get that right 
RC>>>Marcus?).

> Why can't you make your engine put comments in the code?

He most likely can. But then he still has to do some arithmetic in the
error messages after having looked up the code. Ok let's get this in
a more detailed exxample. Lets look at what a potential xml-template
based code generator might do. Not that the example makes much sense
- sorry for that - but i had to find an easy warning. and I also had
to come up with a very easy generator, for that i hope my mini template
stuff is self explanatory....

file-a.pxp: The template
1. <template><code><![CDATA[include 'file-b.php';]]></code>
2. <include file='file-c.inc'/>
3. <code><![CDATA[var_dump(in_array(1,1));]]</code>
4. <finalize/>
5. </template>

file-b.php: Some valid php file
1. <?php
2. var_dump(in_array(1,1));
3. ?>

file-c.inc: Some code note that we do not have '<?php' here
1. var_dump(in_array(1,1));
2. var_dump(in_array(1,1));

output.php: generated file
1. <?php #line 1 "file-a.pxp"
2. include 'file-b.php';     // line 1, file-a.pxp, include errors unchanged
3. #line 1 "file-c.inc"
4. var_dump(in_array(1,1));  // line 1, file-c.php
5. var_dump(in_array(1,1));  // line 2, file-c.php
6. #line 3 "file-a.pxp"
7. var_dump(in_array(1,1));  // line 3, file-a.pxp
8. #line 9 "output.php"
9. var_dump(in_array(1,1));

Now the above works quite fine and for all errors you get the correct
original source location:

Warning: in_array() expects parameter 2 to be array, integer given in file-b.php on line 2
NULL

Warning: in_array() expects parameter 2 to be array, integer given in file-c.inc on line 1
NULL

Warning: in_array() expects parameter 2 to be array, integer given in file-c.inc on line 2
NULL

Warning: in_array() expects parameter 2 to be array, integer given in file-a.pxp on line 3
NULL

Warning: in_array() expects parameter 2 to be array, integer given in output.php on line 9
NULL

The problem is that not all generator output all line informations. That
is some only get the directive for the original input file. And others
create their own code but do not start those blocks with line directives.

Case one means the second error message would be
output.php: generated file
1. <?php #line 1 "file-a.pxp"
2. include 'file-b.php';     // line 1, file-a.pxp, include errors unchanged
4. var_dump(in_array(1,1));  // line 2, file-a.pxp
5. var_dump(in_array(1,1));  // line 3, file-a.pxp
6. #line 3 "file-a.pxp"
7. var_dump(in_array(1,1));  // line 4, file-a.pxp
9. var_dump(in_array(1,1));

Now the error in line 5 is output as line 3 in file-a.pxp. It will take
you an endless amount to locate the original source. And this is exactly
what happens when you work with comments, only then you even get the
error message as output.php.

In the second case the problem is the omitted line 8 which leads to the
last error been seen as line 5 of file-a.pxp. This will make you think
either your code generator or php is broken.

Best regards,
 Marcus