Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24412 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58040 invoked by uid 1010); 16 Jul 2006 08:31:04 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 58025 invoked from network); 16 Jul 2006 08:31:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Jul 2006 08:31:04 -0000 X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:39146] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id C4/5D-11992-649F9B44 for ; Sun, 16 Jul 2006 04:31:03 -0400 Received: from baumbart.mbo (dslb-084-063-024-149.pools.arcor-ip.net [84.63.24.149]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 62ABD35C204; Sun, 16 Jul 2006 10:30:59 +0200 (CEST) Date: Sun, 16 Jul 2006 10:31:05 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <25007351.20060716103105@marcus-boerger.de> To: Robert Cummings Cc: ceo@l-i-e.com, pierre.php@gmail.com, internals@lists.php.net In-Reply-To: <1153018028.3177.4.camel@blobule> References: <347185750.20060715202622@marcus-boerger.de> <20060715204801.4e02c985@pierre-u64> <56975.64.4.222.245.1153017351.squirrel@www.l-i-e.com> <1153018028.3177.4.camel@blobule> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Long awaited line directive From: helly@php.net (Marcus Boerger) Hello Robert, Sunday, July 16, 2006, 4:47:08 AM, you wrote: > On Sat, 2006-07-15 at 22:35, Richard Lynch wrote: >> On Sat, July 15, 2006 1:48 pm, Pierre wrote: >> > On Sat, 15 Jul 2006 20:26:22 +0200 >> > mail@marcus-boerger.de (Marcus Boerger) wrote: >> > >> >> Hello internals, >> >> >> >> attached is a patch that brings the '#line' directive to php. >> >> This is especially usefull for parser generators or any other >> >> code shuffling/generator tools. Any opinions? If nothing speaks >> >> against i'd like to commit this before heading towards OSCON >> >> be end of next week. (oatch is against head of course). >> >> >> > >> > To complete the request, one example (if you are not familiar with >> > other generators or languages): >> > >> > 1. include 'somfile.php' >> > 2. >> > #line 1 "linedirective.php" >> > 4. class Foo // treated as line 1 >> >> Please don't do this. >> >> It's hard enough to get the masses of PHP users to provide decent >> source and line number matchups to help them debug their messes as it >> is. >> >> They're just going to use this to make life much much worse... >> >> I can understand why there are SOME uber-geek desires for this, but, >> honestly, I just don't see the benefits outweighing the nightmare it >> creates... > This has some really good implications for helping PHP users get the > line numbers more correct. For instance, from what I gather, my template > engine can use this to dynamically generate PHP code from an XML tag and > when the generated code fails due to some syntax error based on the > tag's attributes, If my engine included this directive then the engine > will tell them in what included template source file and on what line > they screwed up rather than them seeing an error that has no obvious > relationship whatsoever to what they did (did I get that right Marcus?). Perfectly correct. Best regards, Marcus