Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:24394
Return-Path: <php_lists@realplain.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 60216 invoked by uid 1010); 15 Jul 2006 12:45:25 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 60197 invoked from network); 15 Jul 2006 12:45:24 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 15 Jul 2006 12:45:24 -0000
X-PHP-List-Original-Sender: php_lists@realplain.com
X-Host-Fingerprint: 209.142.136.132 msa2-mx.centurytel.net Linux 2.4/2.6
Received: from ([209.142.136.132:60254] helo=msa2-mx.centurytel.net)
	by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP
	id 76/C6-11992-163E8B44 for <internals@lists.php.net>; Sat, 15 Jul 2006 08:45:23 -0400
Received: from pc1 (d31-79.rt-bras.wnvl.centurytel.net [69.179.158.79])
	by msa2-mx.centurytel.net (8.13.6/8.13.6) with SMTP id k6FCjF1a002238;
	Sat, 15 Jul 2006 07:45:15 -0500
Message-ID: <00b301c6a80c$85dc7790$0201a8c0@pc1>
To: "Marcus Boerger" <helly@php.net>
Cc: <internals@lists.php.net>
References: <009a01c69848$06f22e80$0201a8c0@pc1> <009f01c69cf9$6b493f30$0201a8c0@pc1> <1772356126.20060701125346@marcus-boerger.de> <008701c6a014$ec07ebd0$0201a8c0@pc1> <56141794.20060706101753@marcus-boerger.de> <00fe01c6a4c7$909ad070$0201a8c0@pc1> <1924756948.20060711203719@marcus-boerger.de> <00a201c6a667$147d5c00$0201a8c0@pc1> <271761716.20060715122437@marcus-boerger.de> <005b01c6a801$5e71fc80$0201a8c0@pc1> <26705546.20060715141440@marcus-boerger.de>
Date: Sat, 15 Jul 2006 07:45:16 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1807
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1807
Subject: Re: [PHP-DEV] [PATCH] array_fill: Allow an array to specify keys
From: php_lists@realplain.com ("Matt W")

Hi Marcus,

----- Original Message ----- 
From: "Marcus Boerger"


> Hello Matt,
>
>   thanks for the update
>
> best regards
> marcus

No problem, but...

HEAD looks good now (meaning how you guys want it), but there's an issue
with 5.2 -- fill and fill_keys will handle "val" passed by reference
differently.  Either fill_keys needs

if (PZVAL_IS_REF(...)) {
    SEPARATE_ZVAL(...);
}

added or that part removed from array_fill to make them behave the same,
right?  (This is just 5.2, HEAD's fine.)

Also, again, with both branches, if you're allowing array_fill_keys to
return an empty array (which I support), shouldn't array_fill be changed to
do the same?

You want consistency where it's expected, right? :-)


Thanks,
Matt