Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:24375
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <007901c6a731$6e36a970$0201a8c0@pc1>
To: <internals@lists.php.net>
Date: Fri, 14 Jul 2006 05:36:56 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: [PATCH] array_fill_keys
From: php_lists@realplain.com ("Matt W")

Hi,

Here's a patch to add the array_fill_keys() function instead of extending
array_fill().  I left the bit of cleanup/tweaks I had done to array_fill.
Can someone please review and let me know if anything needs changing?

I have a feeling something will still be wrong it -- works fine, but with
recent code changes, it looks like you're switching to
zend_parse_parameters() where ...get_parameters_ex() had been used.  Of
course I used get_parameters, following array_fill.  So do I need to change
it, and is that only for MAIN branch?  Also wasn't sure if I should mark the
new function "U"nicode compatible.

I'm just going to link to the files instead of attaching.  I made simple
tests for array_fill_keys(), but I couldn't add a new file to CVS, so it's a
separate file.  I don't have diffs online yet for PHP_5_2 -- wanted to get
these looked at first. :-)

http://realplain.com/php/array_fill_keys.diff
http://realplain.com/php/array_fill_keys.phpt

Thanks if you give this attention,
Matt