Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:24206
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Sat, 24 Jun 2006 11:35:17 +0200
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <19910612231.20060624113517@marcus-boerger.de>
To: Andrei Zmievski <andrei@gravitonic.com>
Cc: Michael Wallner <mike@php.net>, php-i18n@lists.php.net,
	<internals@lists.php.net>
In-Reply-To: <c4121e769b817895e787154fc9a7b51a@gravitonic.com>
References: <23ead5a35bff30e24f93045de3db6638@gravitonic.com> <449C5A1A.3080407@php.net> <c4121e769b817895e787154fc9a7b51a@gravitonic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-I18N] Re: [PHP-DEV] Re: TextIterator changes
From: helly@php.net (Marcus Boerger)

Hello Andrei,

  you should reconsider giving it full iterator interface. Adding more
functionality is of course quite easy and no problem at all. Sharing an
interface also makes the whole thing feel much better as in no conflicts
as in consistent. Actually that's what interfaces are for.

Friday, June 23, 2006, 11:20:28 PM, you wrote:

> TextIterator does not implement Iterator interface, only Traversable. 
> It just happens to have functions of the same name as Iterator.

> -Andrei

> On Jun 23, 2006, at 2:16 PM, Michael Wallner wrote:

>> Andrei Zmievski wrote:
>>> I am working on implementing BreakIterator API [1]. I considered two 
>>> approaches: making a separate class or merging the API into the 
>>> existing TextIterator. Having a separate class would be a bit 
>>> cleaner, but I can see people wanting to use it in foreach(), and 
>>> since TextIterator already provides a lot of BreakIterator's 
>>> functionality, I decided that merging would be the best option. 
>>> However, there is an overlap between the BreakIterator API and the 
>>> current TextIterator one, so there will have to be some changes.
>>> 1. TextIterator::current() signature will change from:
>>>    mixed current()
>>> to:
>>>    mixed current(integer &$offset)
>>
>> This will raise the same issue as we have/had with the reflection API:
>> mike@honeybadger:~/build/php-unicode-debug$ cli -r 'interface 
>> i{function f();} class c implements i{function f($a){}}'
>>
>> Fatal error: Declaration of c::f() must be compatible with that of 
>> i::f() in Command line code on line 1
>>
>>
>> Nah, don't look at me--I don't like that either.
>>
>>
>>> 3. TextIterator::rewind() will be renamed to TextIterator::first() to 
>>> conform to BreakIterator's first()/last() API.
>>> So this is heads up. Let me know if you have a problem with this.
>>
>> Huh? Rename or alias? It can't implement Iterator if there's no 
>> rewind() method.

Best regards,
 Marcus