Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24171 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35439 invoked by uid 1010); 21 Jun 2006 17:19:09 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 35423 invoked from network); 21 Jun 2006 17:19:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jun 2006 17:19:09 -0000 X-PHP-List-Original-Sender: list@firehawksystems.com X-Host-Fingerprint: 204.11.219.140 ls6.firehawksystems.com Received: from ([204.11.219.140:63184] helo=ls6.firehawksystems.com) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id 99/13-10952-B8F79944 for ; Wed, 21 Jun 2006 13:19:07 -0400 Received: from [216.145.57.228] (bfrance-mac.corp.yahoo.com [216.145.57.228]) (authenticated bits=0) by ls6.firehawksystems.com (8.13.6/8.13.6) with ESMTP id k5LHJ77l007350 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO) for ; Wed, 21 Jun 2006 10:19:07 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v750) Content-Transfer-Encoding: 7bit Message-ID: Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed To: internals Mailing List Date: Wed, 21 Jun 2006 13:19:14 -0400 X-Mailer: Apple Mail (2.750) X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on ls6.firehawksystems.com X-Virus-Status: Clean X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,J_CHICKENPOX_62, TW_BX,TW_IB autolearn=no version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on ls6.firehawksystems.com Subject: php_compat.h XML clean up From: list@firehawksystems.com ("Brian J. France") I think the xml stuff in php_compat.h needs some attention. The gd defines need moved out side of the xml stuff and only things from expat_compat.h need compat'ed. This patch is what I was thinking: http://www.brianfrance.com/software/php/php_compat.h.patch This also adds one that is used but not in there. Comments? This all came about because a property of ours is moving to PHP 5 and is using expat. Turns out the only real solution for them is to either move to libxml2 or define PHP_COMPAT_H before include all the PHP headers. If they don't define PHP_COMPAT_H before including the headers they will calling php_XML_ParserCreate to create a php_XML_Parser and then try to send that to XML_SetCdataSectionHandler (which isn't compat'ed) and things will go boom (in theory). Brian