Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24120 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35503 invoked by uid 1010); 14 Jun 2006 05:52:30 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 35487 invoked from network); 14 Jun 2006 05:52:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Jun 2006 05:52:30 -0000 X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:51184] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id BD/49-00253-D14AF844 for ; Wed, 14 Jun 2006 01:52:30 -0400 Received: (qmail 29910 invoked from network); 14 Jun 2006 05:51:53 -0000 Received: from internal.zend.office (HELO thinkpad) (10.1.1.1) by internal.zend.office with SMTP; 14 Jun 2006 05:51:53 -0000 To: "'Frank M. Kromann'" Cc: Date: Wed, 14 Jun 2006 09:52:15 +0400 Message-ID: <009601c68f76$b26abb90$6e02a8c0@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook, Build 10.0.6626 In-Reply-To: <11502263720120000@9866357972520000.9866341568840000> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2869 Importance: Normal Subject: RE: Last patch breaks ODBC From: dmitry@zend.com ("Dmitry Stogov") References: <11502263720120000@9866357972520000.9866341568840000> Thank you for catching me. Fixed. Thanks. Dmitry. > -----Original Message----- > From: Frank M. Kromann [mailto:frank@kromann.info] > Sent: Tuesday, June 13, 2006 11:20 PM > To: dmitry@php.net > Cc: internals@lists.php.net > Subject: Last patch breaks ODBC > > > Hi Dmitry, > > Your last module cleanup patch seams to break compilation on > ext/odbc/php_udbc.c. Would it be safe to reverrt this? The > odbc module does not use global variables. > > - Frank > > > cvs diff -u -- php_odbc.c (in directory C:\PHP\php6\ext\odbc\) > Index: php_odbc.c > =================================================================== > RCS file: /repository/php-src/ext/odbc/php_odbc.c,v > retrieving revision 1.195 > diff -u -r1.195 php_odbc.c > --- php_odbc.c 13 Jun 2006 13:12:19 -0000 1.195 > +++ php_odbc.c 13 Jun 2006 19:16:16 -0000 > @@ -131,7 +131,6 @@ > /* }}} */ > > ZEND_DECLARE_MODULE_GLOBALS(odbc); > -static PHP_GINIT_FUNCTION(odbc); > > /* {{{ odbc_module_entry > */ > @@ -145,8 +144,8 @@ > PHP_RSHUTDOWN(odbc), > PHP_MINFO(odbc), > "1.0", > - PHP_MODULE_GLOBALS(odbc), > - PHP_GINIT(odbc), > + NULL, > + NULL, > NULL, > NULL, > STANDARD_MODULE_PROPERTIES_EX > @@ -404,11 +403,6 @@ > PHP_INI_END() > /* }}} */ > > -static PHP_GINIT_FUNCTION(odbc) > -{ > - odbc_globals->num_persistent = 0; > -} > - > /* {{{ PHP_MINIT_FUNCTION */ > PHP_MINIT_FUNCTION(odbc) > { > > > > > > >