Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24116 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62251 invoked by uid 1010); 13 Jun 2006 19:19:43 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 62236 invoked from network); 13 Jun 2006 19:19:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Jun 2006 19:19:43 -0000 X-PHP-List-Original-Sender: frank@kromann.info X-Host-Fingerprint: 64.186.239.125 c-064-186-239-125.oc1.redwire.net Linux 2.5 (sometimes 2.4) (4) Received: from ([64.186.239.125:35182] helo=mail.kromann.info) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id F0/3C-00253-ECF0F844 for ; Tue, 13 Jun 2006 15:19:43 -0400 Received: by mail.kromann.info (Postfix, from userid 510) id 5601F4040CD; Tue, 13 Jun 2006 12:19:38 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on mail.kromann.info X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=AWL,UPPERCASE_25_50 autolearn=ham version=3.1.1 Received: from warp (www.kromann.info [64.186.239.115]) by mail.kromann.info (Postfix) with SMTP id E79304040CB; Tue, 13 Jun 2006 12:19:37 -0700 (PDT) To: Cc: X-Mailer: Swwwing 2000 Message-ID: <11502263720120000@9866357972520000.9866341568840000> MIME-Version: 1.0 Reply-To: "Frank M. Kromann" Date: Tue, 13 Jun 2006 12:19:32 -0700 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: Last patch breaks ODBC From: frank@kromann.info ("Frank M. Kromann") Hi Dmitry, Your last module cleanup patch seams to break compilation on ext/odbc/php_udbc.c. Would it be safe to reverrt this? The odbc module does not use global variables. - Frank cvs diff -u -- php_odbc.c (in directory C:\PHP\php6\ext\odbc\) Index: php_odbc.c =================================================================== RCS file: /repository/php-src/ext/odbc/php_odbc.c,v retrieving revision 1.195 diff -u -r1.195 php_odbc.c --- php_odbc.c 13 Jun 2006 13:12:19 -0000 1.195 +++ php_odbc.c 13 Jun 2006 19:16:16 -0000 @@ -131,7 +131,6 @@ /* }}} */ ZEND_DECLARE_MODULE_GLOBALS(odbc); -static PHP_GINIT_FUNCTION(odbc); /* {{{ odbc_module_entry */ @@ -145,8 +144,8 @@ PHP_RSHUTDOWN(odbc), PHP_MINFO(odbc), "1.0", - PHP_MODULE_GLOBALS(odbc), - PHP_GINIT(odbc), + NULL, + NULL, NULL, NULL, STANDARD_MODULE_PROPERTIES_EX @@ -404,11 +403,6 @@ PHP_INI_END() /* }}} */ -static PHP_GINIT_FUNCTION(odbc) -{ - odbc_globals->num_persistent = 0; -} - /* {{{ PHP_MINIT_FUNCTION */ PHP_MINIT_FUNCTION(odbc) {