Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:24002
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <108001c68b29$6f93b930$6602a8c0@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "Rasmus Lerdorf" <rasmus@lerdorf.com>
Cc: "Dmitry Stogov" <dmitry@zend.com>, <internals@lists.php.net>,
	"Ilia Alshanetsky" <ilia@prohost.org>, "Andi Gutmans" <andi@zend.com>
References: <000001c68af5$50876930$6e02a8c0@thinkpad> <7.0.1.0.2.20060608110050.0521bb48@zend.com> <105301c68b27$e80c8d80$6602a8c0@foxbox> <44886B6D.8010801@lerdorf.com>
Date: Thu, 8 Jun 2006 20:29:09 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="Windows-1252";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [PATCH] Automatic module globals management
From: steph@zend.com ("Steph Fox")

Hi Rasmus,

>> It'd make more sense to apply the patch partially in 5_2 and change the 
>> module API number (to address that issue and give extension authors some 
>> hope of understanding what's going on), and apply the whole thing in HEAD 
>> and bump the API number again. I really think applying it in 5_2 is going 
>> to leave extension writers with a headache.
>
> As soon as you change the module api number you have a headache.  At 
> Yahoo! we would need to compile some 200 or so custom extensions.  If we 
> are forced to do that, a little tweak in the code itself is minor.

We aren't _forced_ to do that, I wrote a small patch over a week ago that 
fixes it internally and doesn't even touch the module_entry struct. But the 
more robust way would be to do as Dmitry's suggesting with the 
ZEND_MG(whatever) part of his patch.

People with custom extensions at least are only working with one version of 
PHP at a time, I'd hope :)

>
> -Rasmus