Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24001 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40607 invoked by uid 1010); 8 Jun 2006 18:27:35 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 40592 invoked from network); 8 Jun 2006 18:27:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Jun 2006 18:27:35 -0000 X-PHP-List-Original-Sender: andi@zend.com X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:43677] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 49/B5-00946-61C68844 for ; Thu, 08 Jun 2006 14:27:35 -0400 Received: (qmail 19654 invoked from network); 8 Jun 2006 18:27:03 -0000 Received: from localhost (HELO ANDI-NOTEBOOK.zend.com) (127.0.0.1) by localhost with SMTP; 8 Jun 2006 18:27:03 -0000 Message-ID: <7.0.1.0.2.20060608112659.062f4690@zend.com> X-Mailer: QUALCOMM Windows Eudora Version 7.0.1.0 Date: Thu, 08 Jun 2006 11:27:27 -0700 To: "Steph Fox" ,"Dmitry Stogov" , ,"Ilia Alshanetsky" In-Reply-To: <105301c68b27$e80c8d80$6602a8c0@foxbox> References: <000001c68af5$50876930$6e02a8c0@thinkpad> <7.0.1.0.2.20060608110050.0521bb48@zend.com> <105301c68b27$e80c8d80$6602a8c0@foxbox> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PATCH] Automatic module globals management From: andi@zend.com (Andi Gutmans) It's not going to be a headache because they can still use it the way it should be done today. For the 5.1.x tree you can do the fixes immediately with the way Dmitry has previously proposed.... At 11:18 AM 6/8/2006, Steph Fox wrote: >Andi, hi, > > >>I read the whole thread. >>I agree with Sara. While I understand where Steph is coming from, I >>still think this is a good change. It would allow us to use this >>method in the current tree right away, and for PECL authors who >>want to stay compatible with older versions they can use the old & >>ugly way of doing it until they feel comfortable in changing over. > >This redesign was presented as a fix for a win32 module API breakage >in PHP 5.1.3 that causes shared modules to crash. Adopting the >proposed changes now won't help in any way for existing extensions, >since everyone's saying 'oh it'll be nice to use it in the future'. >It just means we're stuck with the status quo, and of course the odd >confused extension author turning up with a strange shutdown crash >under win32 that didn't used to happen in PHP 5.1.2. > >It'd make more sense to apply the patch partially in 5_2 and change >the module API number (to address that issue and give extension >authors some hope of understanding what's going on), and apply the >whole thing in HEAD and bump the API number again. I really think >applying it in 5_2 is going to leave extension writers with a headache. > >- Steph > > >