Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:24000
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <44886B6D.8010801@lerdorf.com>
Date: Thu, 08 Jun 2006 11:24:45 -0700
User-Agent: Thunderbird 3.0a1 (Macintosh/20060414)
MIME-Version: 1.0
To: Steph Fox <steph@zend.com>
CC: Dmitry Stogov <dmitry@zend.com>, internals@lists.php.net,
	Ilia Alshanetsky <ilia@prohost.org>, Andi Gutmans <andi@zend.com>
References: <000001c68af5$50876930$6e02a8c0@thinkpad> <7.0.1.0.2.20060608110050.0521bb48@zend.com> <105301c68b27$e80c8d80$6602a8c0@foxbox>
In-Reply-To: <105301c68b27$e80c8d80$6602a8c0@foxbox>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [PATCH] Automatic module globals management
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Steph Fox wrote:
> Andi, hi,
> 
> 
>> I read the whole thread.
>> I agree with Sara. While I understand where Steph is coming from, I 
>> still think this is a good change. It would allow us to use this 
>> method in the current tree right away, and for PECL authors who want 
>> to stay compatible with older versions they can use the old & ugly way 
>> of doing it until they feel comfortable in changing over.
> 
> This redesign was presented as a fix for a win32 module API breakage in 
> PHP 5.1.3 that causes shared modules to crash. Adopting the proposed 
> changes now won't help in any way for existing extensions, since 
> everyone's saying 'oh it'll be nice to use it in the future'. It just 
> means we're stuck with the status quo, and of course the odd confused 
> extension author turning up with a strange shutdown crash under win32 
> that didn't used to happen in PHP 5.1.2.
> 
> It'd make more sense to apply the patch partially in 5_2 and change the 
> module API number (to address that issue and give extension authors some 
> hope of understanding what's going on), and apply the whole thing in 
> HEAD and bump the API number again. I really think applying it in 5_2 is 
> going to leave extension writers with a headache.

As soon as you change the module api number you have a headache.  At 
Yahoo! we would need to compile some 200 or so custom extensions.  If we 
are forced to do that, a little tweak in the code itself is minor.

-Rasmus