Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:23999
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <105301c68b27$e80c8d80$6602a8c0@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "Dmitry Stogov" <dmitry@zend.com>, <internals@lists.php.net>,
	"Ilia Alshanetsky" <ilia@prohost.org>, "Andi Gutmans" <andi@zend.com>
References: <000001c68af5$50876930$6e02a8c0@thinkpad> <7.0.1.0.2.20060608110050.0521bb48@zend.com>
Date: Thu, 8 Jun 2006 20:18:11 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="Windows-1252";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] Automatic module globals management
From: steph@zend.com ("Steph Fox")

Andi, hi,


>I read the whole thread.
> I agree with Sara. While I understand where Steph is coming from, I still 
> think this is a good change. It would allow us to use this method in the 
> current tree right away, and for PECL authors who want to stay compatible 
> with older versions they can use the old & ugly way of doing it until they 
> feel comfortable in changing over.

This redesign was presented as a fix for a win32 module API breakage in PHP 
5.1.3 that causes shared modules to crash. Adopting the proposed changes now 
won't help in any way for existing extensions, since everyone's saying 'oh 
it'll be nice to use it in the future'. It just means we're stuck with the 
status quo, and of course the odd confused extension author turning up with 
a strange shutdown crash under win32 that didn't used to happen in PHP 
5.1.2.

It'd make more sense to apply the patch partially in 5_2 and change the 
module API number (to address that issue and give extension authors some 
hope of understanding what's going on), and apply the whole thing in HEAD 
and bump the API number again. I really think applying it in 5_2 is going to 
leave extension writers with a headache.

- Steph