Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:23995
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <101101c68b1d$62e2eff0$6602a8c0@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "Stanislav Malyshev" <stas@zend.com>,
	"Dmitry Stogov" <dmitry@zend.com>
Cc: <internals@lists.php.net>
References: <000001c68af5$50876930$6e02a8c0@thinkpad> <Pine.LNX.4.64.0606081953160.2164@shire.zend.office>
Date: Thu, 8 Jun 2006 19:02:54 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="Windows-1252";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Automatic module globals management
From: steph@zend.com ("Steph Fox")

> DS>>The attached patch (for PHP_5_2) implements automatic management of 
> module
> DS>>globals.
> DS>>The problem that module globals must be unregistered before extension
> DS>>unloading, because "globls_dtor" function is unloaded together with
> DS>>extension and cannot be called.
>
> I think the patch itself looks fine, and makes globals management cleaner.
> However, I'm not sure it would be for 5.2 for reasons cited by Steph -
> probably not a lot of extension would be reworked specifically for 5.2
> (correct me if I'm wrong here) but for 6.0 probably most of them would
> need some massaging here and there, so putting it in 6.0 is quite OK, but
> putting it into 5.2 probably would not be used too much outside the engine
> modules - for which it doesn't matter much since we can fix them with old
> API as far as I see.

We can, but Dmitry broke the old API for win32 with his DL_UNLOAD exposure 
(which is where this redesign began). So a lot of modules simply won't work 
there without a little massaging at present - not a huge problem within PHP 
itself, but a niggling one for anyone with a non-public extension who 
thought they could just upgrade to PHP 5.1.3 and up.

(A _very_ little massaging, but it's still a broken API.)

I think we need to fix that API breakage in 5_2 regardless of what happens 
with this patch...

- Steph