Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:23994 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 3391 invoked by uid 1010); 8 Jun 2006 16:57:49 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 3376 invoked from network); 8 Jun 2006 16:57:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Jun 2006 16:57:49 -0000 X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:23994] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id FE/C1-00946-90758844 for ; Thu, 08 Jun 2006 12:57:48 -0400 Received: (qmail 26741 invoked from network); 8 Jun 2006 16:57:13 -0000 Received: from shire.zend.office (10.1.2.160) by internal.zend.office with SMTP; 8 Jun 2006 16:57:13 -0000 Date: Thu, 8 Jun 2006 19:57:13 +0300 (IDT) X-X-Sender: frodo@shire.zend.office To: Dmitry Stogov cc: internals@lists.php.net In-Reply-To: <000001c68af5$50876930$6e02a8c0@thinkpad> Message-ID: References: <000001c68af5$50876930$6e02a8c0@thinkpad> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] [PATCH] Automatic module globals management From: stas@zend.com (Stanislav Malyshev) DS>>The attached patch (for PHP_5_2) implements automatic management of module DS>>globals. DS>>The problem that module globals must be unregistered before extension DS>>unloading, because "globls_dtor" function is unloaded together with DS>>extension and cannot be called. I think the patch itself looks fine, and makes globals management cleaner. However, I'm not sure it would be for 5.2 for reasons cited by Steph - probably not a lot of extension would be reworked specifically for 5.2 (correct me if I'm wrong here) but for 6.0 probably most of them would need some massaging here and there, so putting it in 6.0 is quite OK, but putting it into 5.2 probably would not be used too much outside the engine modules - for which it doesn't matter much since we can fix them with old API as far as I see. -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115