Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:23845
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <7.0.1.0.2.20060531232613.03cd05c8@zend.com>
Date: Wed, 31 May 2006 23:28:49 -0700
To: "Steph Fox" <steph@zend.com>,"Frank M. Kromann" <frank@kromann.info>
Cc: "'internals'" <internals@lists.php.net>,
	"'Antony Dovgal'" <antony@zend.com>,"Dmitry Stogov" <dmitry@zend.com>,
	"'Xuefer'" <xuefer@gmail.com>
In-Reply-To: <09f801c68536$f18f0cd0$6602a8c0@foxbox>
References: <11490874854760000@9866357972520000.9866341568840000>
	<091901c684c6$390ef370$6602a8c0@foxbox>
	<7.0.1.0.2.20060531212500.03758ec8@zend.com>
	<09f801c68536$f18f0cd0$6602a8c0@foxbox>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
From: andi@zend.com (Andi Gutmans)

As we are not planning to release a new version within the next 
couple of weeks, I suggest before jumping to conclusions we take a look at it.

If you really need to comment out that line in the meanwhile that's OK with me.

Andi

At 09:50 PM 5/31/2006, Steph Fox wrote:
>>>Yes, it would, given the root cause - but would you really want to 
>>>break the whole of PHP for an academic exercise?
>>
>>It's not really an academic exercise. If we know there's a bug 
>>someplace we should at least look into it and try and understand it.
>
>Frank's referring to Zeev's three-years-ago decision to simply opt 
>out of tsrm_shutdown() here... he's suggesting we revert it.
>
>>Then if we decide to remove the trsm_shutdown call for a good 
>>reason (circular dependency, blah blah blah) then we can do that 
>>and put a nice fat comment on why it's the right thing to do. But I 
>>do think it's benefical to try and understand what's happening.
>
>Fine, but breaking working code while you're trying to understand 
>what's happening is far from beneficial to our users. Can't we at least #0 it?
>
>>
>>Andi