Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:23844
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: Steph Fox <steph@zend.com>
Cc: 'internals' <internals@lists.php.net>,
	'Antony Dovgal' <antony@zend.com>, Dmitry Stogov <dmitry@zend.com>,
	'Xuefer' <xuefer@gmail.com>, Andi Gutmans <andi@zend.com>
Message-ID: <11491392660720000@9866357972520000.9866341568840000>
MIME-Version: 1.0
Reply-To: "Frank M. Kromann" <frank@kromann.info>
Date: Wed, 31 May 2006 22:21:06 -0700
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
From: frank@kromann.info ("Frank M. Kromann")



> >>Yes, it would, given the root cause - but would you really want to
break 
> >>the whole of PHP for an academic exercise?
> >
> > It's not really an academic exercise. If we know there's a bug
someplace 
> > we should at least look into it and try and understand it.
> 
> Frank's referring to Zeev's three-years-ago decision to simply opt out
of 
> tsrm_shutdown() here... he's suggesting we revert it.
> 
> > Then if we decide to remove the trsm_shutdown call for a good reason 
> > (circular dependency, blah blah blah) then we can do that and put a
nice 
> > fat comment on why it's the right thing to do. But I do think it's 
> > benefical to try and understand what's happening.
> 
> Fine, but breaking working code while you're trying to understand what's

> happening is far from beneficial to our users. Can't we at least #0 it?

There is no need to break code. The shutdown function was commented out
for a reason (crash) when that's fixed we can enable that code again.

- Frank