Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:23411
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <000901c67857$c20fa190$0100a8c0@pc07653>
To: "Andrei Zmievski" <andrei@gravitonic.com>,
	"Derick Rethans" <derick@php.net>
Cc: "PHPdev" <internals@lists.php.net>
References: <003d01c672ef$6cde8370$0100a8c0@pc07653> <517361123ef66114064e2866c95e3caa@gravitonic.com> <Pine.LNX.4.62.0605090902240.3872@localhost> <f2af927c95d6a78c5b94f18521fec520@gravitonic.com>
Date: Mon, 15 May 2006 20:42:53 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [php6] accepting an ascii string only
From: nlopess@php.net ("Nuno Lopes")

Sorry for the delay.
But I think that a new type specifier could be introduced. If not you are 
saying to extensions writers to duplicate the code below a hundred times:

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "t", &name, &name_len, 
&name_type) == FAILURE) {
    return;
}

if (name_type == IS_UNICODE) {
    buf = zend_unicode_to_ascii(name, name_len TSRMLS_CC);
    if (buf == NULL) {
        php_error(E_WARNING, "my_var has to consist only of ASCII 
characters");
        RETURN_FALSE;
    }
} else {
    buf = (char *) name;
}


With a new specifier you would be sure that the string you received was 
ASCII-only and wouldn't have to care with conversions and such.

Nuno


> Check out ext/unicode/property.c where zend_unicode_to_ascii() is being 
> used.
>
> -Andrei
>
> On May 9, 2006, at 12:02 AM, Derick Rethans wrote:
>
>> On Mon, 8 May 2006, Andrei Zmievski wrote:
>>
>>> There is no way to do it right now. I could see it being useful, though.
>>> Anyone else have an opinion on this?
>>
>> I think we should have a look at it when there is a real need for it as
>> I think it's going to be a pain for the users...
>>
>> Derick