Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:23249 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72885 invoked by uid 1010); 11 May 2006 14:22:51 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 72870 invoked from network); 11 May 2006 14:22:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 May 2006 14:22:51 -0000 X-PHP-List-Original-Sender: lsmith@php.net X-Host-Fingerprint: 212.112.227.169 ipx11223.ipxserver.de Linux 2.5 (sometimes 2.4) (4) Received: from ([212.112.227.169:43097] helo=ipx11223.ipxserver.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 99/91-19568-AB843644 for ; Thu, 11 May 2006 10:22:50 -0400 Received: from localhost (localhost [127.0.0.1]) by ipx11223.ipxserver.de (Postfix) with ESMTP id B9AF5DF000D; Thu, 11 May 2006 16:24:04 +0200 (CEST) Received: from ipx11223.ipxserver.de ([127.0.0.1]) by localhost (ipx11223 [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 31484-04; Thu, 11 May 2006 16:23:56 +0200 (CEST) Received: from [127.0.0.1] (i577B6325.versanet.de [87.123.99.37]) by ipx11223.ipxserver.de (Postfix) with ESMTP id 0BE21DF000B; Thu, 11 May 2006 16:23:56 +0200 (CEST) Message-ID: <446348AC.3050503@php.net> Date: Thu, 11 May 2006 16:22:36 +0200 User-Agent: Thunderbird 1.5.0.2 (Windows/20060308) MIME-Version: 1.0 To: pierre.php@gmail.com Cc: internals@lists.php.net, Derick Rethans References: <20060511143720.33323294@localhost.localdomain> In-Reply-To: <20060511143720.33323294@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by somedaemon at backendmedia.com Subject: Re: Stop Breaking Our Apps For the Sake of OO From: lsmith@php.net (Lukas Smith) Pierre wrote: > On Thu, 11 May 2006 14:15:53 +0200 (CEST) > derick@php.net (Derick Rethans) wrote: > >> Hello! >> >> While I welcome new developments in either procedural or OO >> interfaces in PHP I do not agree with breaking BC (between 5.1 and >> 5.2 in this case) just for the sake of OO purity. In this example >> there is the following class: > > I forgot to mention how vicious such changes can be. Most of times the > related tests are "updated" in the same commit (or right after) to > follow the new behavior. Making nearly impossible to know about the > breakages without duplicating core tests in our apps. Also commit > messages or changelog entries are rarely explicit enough to mention > them. Yeah, modifications that require changes to existing tests due to BC breakage should get a clear label in the NEWS file that makes it clear that its a BC break. Otherwise things slip through the radar unnoticed or the scope of the change is never put to discussion. regards, Lukas