Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22964 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20875 invoked by uid 1010); 25 Apr 2006 19:29:37 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 20859 invoked from network); 25 Apr 2006 19:29:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Apr 2006 19:29:37 -0000 X-PHP-List-Original-Sender: pollita@php.net X-Host-Fingerprint: 69.12.155.130 69-12-155-130.dsl.static.sonic.net Linux 2.4/2.6 Received: from ([69.12.155.130:1350] helo=pigeon.alphaweb.net) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 1B/C9-19715-1A87E444 for ; Tue, 25 Apr 2006 15:29:37 -0400 Received: from localhost ([127.0.0.1] helo=OHRLVN4523SG) by pigeon.alphaweb.net with smtp (Exim 4.10) id 1FYScm-0003Xn-00; Tue, 25 Apr 2006 11:51:02 -0700 Message-ID: <006201c6689e$9262d570$7eb81a44@OHRLVN4523SG> To: Cc: "\"Wez Furlong\"" , "Andrei Zmievski" References: <4e89b4260604242246i2f274c62sc4c9618031a3836c@mail.gmail.com> Date: Tue, 25 Apr 2006 12:29:21 -0700 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2670 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2670 Subject: Re: [PHP-DEV] ZSTR and NULL problems again From: pollita@php.net ("Sara Golemon") Agreed.... Unless someone goes ahead and changes the get_line macro and places that call it, I'll do so when I get to the end of my second leg... -Sara ----- Original Message ----- From: ""Wez Furlong"" Newsgroups: php.internals To: "Andrei Zmievski" Cc: "PHP Internals" ; "Dmitry Stogov" ; "Frank M. Kromann" Sent: Monday, April 24, 2006 10:46 PM Subject: Re: [PHP-DEV] ZSTR and NULL problems again I think ZSTR(buf) should not be present in the macro: #define php_stream_get_line(stream, buf, maxlen, retlen) _php_stream_get_line((stream), IS_STRING, (buf), (maxlen), 0, (retlen) TSRMLS_CC) Let the caller apply ZSTR() to the argument manually, if that is required. --Wez. On 4/24/06, Andrei Zmievski wrote: > #define php_stream_get_line(stream, buf, maxlen, retlen) > _php_stream_get_line((stream), IS_STRING, ZSTR(buf), (maxlen), 0, > (retlen) TSRMLS_CC)