Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22963 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 24413 invoked by uid 1010); 25 Apr 2006 15:51:47 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 24397 invoked from network); 25 Apr 2006 15:51:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Apr 2006 15:51:47 -0000 X-PHP-List-Original-Sender: frank@kromann.info X-Host-Fingerprint: 64.186.239.125 c-064-186-239-125.oc1.redwire.net Linux 2.5 (sometimes 2.4) (4) Received: from ([64.186.239.125:55998] helo=mail.kromann.info) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 80/CC-19715-2954E444 for ; Tue, 25 Apr 2006 11:51:46 -0400 Received: from warp (www.kromann.info [64.186.239.115]) by mail.kromann.info (Postfix) with SMTP id E87144040AF; Tue, 25 Apr 2006 08:51:42 -0700 (PDT) To: Wez Furlong Cc: PHP Internals , Dmitry Stogov , Andrei Zmievski X-Mailer: Swwwing 2000 Message-ID: <11459802890160000@9866357972520000.9866341568840000> MIME-Version: 1.0 Reply-To: "Frank M. Kromann" Date: Tue, 25 Apr 2006 08:51:29 -0700 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] ZSTR and NULL problems again From: frank@kromann.info ("Frank M. Kromann") I Like that idea. - Frank > I think ZSTR(buf) should not be present in the macro: > > #define php_stream_get_line(stream, buf, maxlen, retlen) > _php_stream_get_line((stream), IS_STRING, (buf), (maxlen), 0, > (retlen) TSRMLS_CC) > > Let the caller apply ZSTR() to the argument manually, if that is required. > > --Wez. > > On 4/24/06, Andrei Zmievski wrote: > > #define php_stream_get_line(stream, buf, maxlen, retlen) > > _php_stream_get_line((stream), IS_STRING, ZSTR(buf), (maxlen), 0, > > (retlen) TSRMLS_CC) >