Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:22915
Return-Path: <frank@kromann.info>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 76148 invoked by uid 1010); 21 Apr 2006 21:26:47 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 76133 invoked from network); 21 Apr 2006 21:26:46 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Apr 2006 21:26:46 -0000
X-Host-Fingerprint: 64.186.239.125 c-064-186-239-125.oc1.redwire.net Linux 2.5 (sometimes 2.4) (4)
Received: from ([64.186.239.125:38008] helo=mail.kromann.info)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id 04/98-19715-61E49444 for <internals@lists.php.net>; Fri, 21 Apr 2006 17:26:46 -0400
Received: from warp (www.kromann.info [64.186.239.115])
	by mail.kromann.info (Postfix) with SMTP id 2E77F4040A3;
	Fri, 21 Apr 2006 14:26:43 -0700 (PDT)
To: Rob Richards <rrichards@ctindustries.net>
Cc: PHP Internals <internals@lists.php.net>
X-Mailer: Swwwing 2000
Message-ID: <11456547787680000@9866357972520000.9866341568840000>
MIME-Version: 1.0
Reply-To: "Frank M. Kromann" <frank@kromann.info>
Date: Fri, 21 Apr 2006 14:26:18 -0700
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Compile head on Win32
From: frank@kromann.info ("Frank M. Kromann")

Hi Rob,

Working on a patch for those as well.

- Frank

> If this patch is used to fix the build, the same change need to be made
in:
> ext/spl/spl_directory.c
> ext/standard/image.c (php_stream_gets)
> sapi/cli/php_cli.c (php_stream_gets)
> 
> Frank M. Kromann wrote:
> > Hello Everyone,
> >
> > Here is a patch that makes it possible to compile HEAD on win32.
> >
> > http://kromann.info/diff-file.c
> >
> > php_stream_get_line_ex() and php_stream_get_line() are both defined
as
> > macros where the buf parameter is replaced with ZSTR(buf). Setting buf
to
> > NULL_ZSTR causes the function to be called with ZSTR(NULL_ZSTR) and
that
> > does not make any sence.
> >
> > Please let me know if it's ok to commit this.
> >
> > - Frank
> >
> >   
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
>