Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22914 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46908 invoked by uid 1010); 21 Apr 2006 20:50:11 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 46892 invoked from network); 21 Apr 2006 20:50:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Apr 2006 20:50:11 -0000 X-Host-Fingerprint: 216.117.147.250 unknown Linux 2.4/2.6 Received: from ([216.117.147.250:60464] helo=ctindustries.net) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id A5/C3-19715-18549444 for ; Fri, 21 Apr 2006 16:50:09 -0400 Received: from [127.0.0.1] (dsta-aa203.pivot.net [66.186.171.203]) (authenticated bits=0) by ctindustries.net (8.12.8/8.12.8) with ESMTP id k3LJZq3w029779; Fri, 21 Apr 2006 15:35:53 -0400 Message-ID: <4449479B.10204@ctindustries.net> Date: Fri, 21 Apr 2006 16:59:07 -0400 User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: "Frank M. Kromann" CC: PHP Internals References: <11456520314200000@9866357972520000.9866341568840000> In-Reply-To: <11456520314200000@9866357972520000.9866341568840000> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 0616-4, 04/21/2006), Outbound message X-Antivirus-Status: Clean X-Virus-Scanned: ClamAV 0.88.1/1411/Thu Apr 20 18:23:28 2006 on ctindustries.net X-Virus-Status: Clean Subject: Re: [PHP-DEV] [PATCH] Compile head on Win32 From: rrichards@ctindustries.net (Rob Richards) If this patch is used to fix the build, the same change need to be made in: ext/spl/spl_directory.c ext/standard/image.c (php_stream_gets) sapi/cli/php_cli.c (php_stream_gets) Frank M. Kromann wrote: > Hello Everyone, > > Here is a patch that makes it possible to compile HEAD on win32. > > http://kromann.info/diff-file.c > > php_stream_get_line_ex() and php_stream_get_line() are both defined as > macros where the buf parameter is replaced with ZSTR(buf). Setting buf to > NULL_ZSTR causes the function to be called with ZSTR(NULL_ZSTR) and that > does not make any sence. > > Please let me know if it's ok to commit this. > > - Frank > >