Newsgroups: php.internals,php.qa
Path: news.php.net
Xref: news.php.net php.internals:229 php.qa:10459
Return-Path: <marcus.boerger@t-online.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 3746 invoked from network); 24 Mar 2003 19:50:15 -0000
Received: from unknown (HELO mailout10.sul.t-online.com) (194.25.134.21)
  by pb1.pair.com with SMTP; 24 Mar 2003 19:50:15 -0000
Received: from fwd04.sul.t-online.de 
	by mailout10.sul.t-online.com with smtp 
	id 18xXxT-0007K2-05; Mon, 24 Mar 2003 20:50:11 +0100
Received: from baumbart.post.rwth-aachen.de (520072483730-0001@[80.142.162.47]) by fwd04.sul.t-online.com
	with esmtp id 18xXxF-0YZDBQC; Mon, 24 Mar 2003 20:49:57 +0100
Reply-to:marcus.boerger@post.rwth-aachen.de
Message-ID: <5.1.0.14.2.20030324204923.02715ed0@mailbox.rwth-aachen.de>
X-Mailer: QUALCOMM Windows Eudora Version 5.1
Date: Mon, 24 Mar 2003 20:49:55 +0100
To: "David Hill (php.net)" <ddhill@php.net>
Cc: Php-Qa <php-qa@lists.php.net>,internals@lists.php.net
In-Reply-To: <004901c2f237$16f6eec0$e3008d10@little1>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
X-Sender: 520072483730-0001@t-dialin.net
Subject: Re: [PHP-QA] Picky about TZ dates...
From: marcus.boerger@t-online.de ((Marcus =?iso-8859-1?Q?B=F6rger?=))
References: <004901c2f237$16f6eec0$e3008d10@little1>

At 19:56 24.03.2003, David Hill (php.net) wrote:
>Hi all,
>     It would seem that Tru64 is pickier about the TZ setting than the 
> rest of the known universe. According to our local TZ expert (who can 
> quote chapter and verse from the UNIX 98 standard) a TZ of GMT is not 
> proper, and GMT0 is (again despite the fact that every other platform 
> seems to have no problem with it)  On all of the machines flavors I have 
> to try, GMT0 works.
>
>This pickyiness causes 3 test "failures" for me.
>
>The affected tests in php5 are:
>../ext/standard/tests/time/002.phpt:     putenv ("TZ=GMT");
>../ext/standard/tests/time/idate.phpt:putenv ("TZ=GMT");
>../ext/standard/tests/time/mktime.phpt:    'GMT',
>
>Unless I hear of any negatives, I would like to change these to GMT0 so I 
>can concentrate on the real bugs.


PASS for mdk 8.2.

Here is the patch

Index: ext/standard/tests/time/002.phpt
===================================================================
RCS file: /repository/php4/ext/standard/tests/time/002.phpt,v
retrieving revision 1.7
diff -u -r1.7 002.phpt
--- ext/standard/tests/time/002.phpt    13 Mar 2003 18:51:39 -0000      1.7
+++ ext/standard/tests/time/002.phpt    24 Mar 2003 20:44:20 -0000
@@ -28,7 +28,7 @@
         "2001-10-22 21:19:58+0213"
         );

-       putenv ("TZ=GMT");
+       putenv ("TZ=GMT0");
         foreach ($dates as $date) {
             echo date ("Y-m-d H:i:s\n", strtotime ($date));
         }
Index: ext/standard/tests/time/idate.phpt
===================================================================
RCS file: /repository/php4/ext/standard/tests/time/idate.phpt,v
retrieving revision 1.2
diff -u -r1.2 idate.phpt
--- ext/standard/tests/time/idate.phpt  17 Feb 2003 06:23:22 -0000      1.2
+++ ext/standard/tests/time/idate.phpt  24 Mar 2003 20:44:20 -0000
@@ -2,7 +2,7 @@
  idate() function
  --FILE--
  <?php
-putenv ("TZ=GMT");
+putenv ("TZ=GMT0");

  $tmp = "UYzymndjHGhgistwLBIW";
  for($a = 0;$a < strlen($tmp); $a++){
Index: ext/standard/tests/time/mktime.phpt
===================================================================
RCS file: /repository/php4/ext/standard/tests/time/mktime.phpt,v
retrieving revision 1.2
diff -u -r1.2 mktime.phpt
--- ext/standard/tests/time/mktime.phpt 9 Feb 2003 12:19:02 -0000       1.2
+++ ext/standard/tests/time/mktime.phpt 24 Mar 2003 20:44:20 -0000
@@ -3,7 +3,7 @@
  --FILE--
  <?php
  $timezones = array(
-    'GMT',
+    'GMT0',
      'GST-1GDT'
  );