Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22863 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51169 invoked by uid 1010); 19 Apr 2006 15:49:12 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 51153 invoked from network); 19 Apr 2006 15:49:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Apr 2006 15:49:12 -0000 X-Host-Fingerprint: 212.55.154.24 relay4.ptmail.sapo.pt Linux 2.4/2.6 Received: from ([212.55.154.24:37895] helo=sapo.pt) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id D5/58-19715-8FB56444 for ; Wed, 19 Apr 2006 11:49:12 -0400 Received: (qmail 29805 invoked by uid 0); 19 Apr 2006 15:47:43 -0000 Received: from unknown (HELO sapo.pt) (10.134.35.159) by relay4 with SMTP; 19 Apr 2006 15:47:43 -0000 Received: (qmail 28501 invoked from network); 19 Apr 2006 15:49:09 -0000 X-AntiVirus: PTMail-AV 0.3.88 X-Virus-Status: Clean (0.00729 seconds) Received: from unknown (HELO pc07653) (nunoplopes@sapo.pt@[81.193.158.96]) (envelope-sender ) by mta9 (qmail-ldap-1.03) with SMTP for ; 19 Apr 2006 15:49:09 -0000 Message-ID: <007401c663c8$c16182c0$0100a8c0@pc07653> To: "Edin Kadribasic" Cc: "Steph Fox" , "internals" References: <09f201c6639c$c8fe39f0$6602a8c0@foxbox> <0a0a01c663a0$755b4230$6602a8c0@foxbox> <008b01c6639d$f39177d0$0100a8c0@pc07653> <0a1f01c663a6$f49711e0$6602a8c0@foxbox> <00a201c6639f$bee582e0$0100a8c0@pc07653> <0a4301c663ac$9cc9bf70$6602a8c0@foxbox> <000701c663a5$35558ab0$0100a8c0@pc07653> <4446215F.7000803@emini.dk> <004a01c663bd$a0f3d160$0100a8c0@pc07653> <44464A68.1070307@emini.dk> Date: Wed, 19 Apr 2006 16:48:50 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0071_01C663D1.22CDDFB0" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2869 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2869 Subject: Re: [PHP-DEV] tiny patch for Tidy From: nlopess@php.net ("Nuno Lopes") ------=_NextPart_000_0071_01C663D1.22CDDFB0 Content-Type: text/plain; format=flowed; charset="Windows-1252"; reply-type=original Content-Transfer-Encoding: 7bit Ah Sorry. I haven't compiled PHP on windows for some time now. Attached is a patch thats fixes the problem. Nuno > Latest CVS (SF anon CVS worked for me) doesn't compile with error: > > ext\tidy\tidy.c(586) : error C2152: 'function' : pointers to functions > with different attributes > > Edin > > > Nuno Lopes wrote: >> answering both e-mails: >> >>> Nuno, which version of libtidy do you think we should use for bundiling >>> with the windows distribution? >> >> >> latest CVS. It is stable ATM (but checkout with a developer account, >> because sourceforge's anonymous cvs servers are currently broken). >> >>> Nuno, will this also work for 4_3 branch? >> >> >> Yep, the libtidy API hasn't changed. >> >> >> Nuno ------=_NextPart_000_0071_01C663D1.22CDDFB0 Content-Type: text/plain; format=flowed; name="php_tidy_win.txt"; reply-type=original Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="php_tidy_win.txt" Index: tidy.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /repository/php-src/ext/tidy/tidy.c,v=0A= retrieving revision 1.66.2.7=0A= diff -u -r1.66.2.7 tidy.c=0A= --- tidy.c 3 Apr 2006 14:59:30 -0000 1.66.2.7=0A= +++ tidy.c 19 Apr 2006 15:46:51 -0000=0A= @@ -333,22 +333,22 @@=0A= ZEND_GET_MODULE(tidy)=0A= #endif=0A= =0A= -void *php_tidy_malloc(size_t len)=0A= +void* TIDY_CALL php_tidy_malloc(size_t len)=0A= {=0A= return emalloc(len);=0A= }=0A= =0A= -void *php_tidy_realloc(void *buf, size_t len)=0A= +void* TIDY_CALL php_tidy_realloc(void *buf, size_t len)=0A= {=0A= return erealloc(buf, len);=0A= }=0A= =0A= -void php_tidy_free(void *buf)=0A= +void TIDY_CALL php_tidy_free(void *buf)=0A= {=0A= efree(buf);=0A= }=0A= =0A= -void php_tidy_panic(ctmbstr msg)=0A= +void TIDY_CALL php_tidy_panic(ctmbstr msg)=0A= {=0A= TSRMLS_FETCH();=0A= php_error_docref(NULL TSRMLS_CC, E_ERROR, "Could not allocate memory = for tidy! (Reason: %s)", (char *)msg);=0A= ------=_NextPart_000_0071_01C663D1.22CDDFB0--