Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22851 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62140 invoked by uid 1010); 19 Apr 2006 10:42:47 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 62125 invoked from network); 19 Apr 2006 10:42:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Apr 2006 10:42:47 -0000 X-Host-Fingerprint: 192.38.9.232 gw2.emini.dk Linux 2.4/2.6 Received: from ([192.38.9.232:1483] helo=gw2.emini.dk) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 18/CD-19715-52416444 for ; Wed, 19 Apr 2006 06:42:46 -0400 Received: by gw2.emini.dk (Postfix, from userid 504) id 82ABCAD4E4; Wed, 19 Apr 2006 12:42:41 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on gw2.emini.dk X-Spam-Detected: no X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Level: Received: from foxbox (unknown [84.228.8.209]) by gw2.emini.dk (Postfix) with ESMTP id 3A527AD4DE; Wed, 19 Apr 2006 12:42:39 +0200 (CEST) Message-ID: <0a1a01c663a6$5a334bf0$6602a8c0@foxbox> Reply-To: "Steph Fox" To: "internals" Cc: "Edin" References: <09f201c6639c$c8fe39f0$6602a8c0@foxbox> <0a0a01c663a0$755b4230$6602a8c0@foxbox> Date: Wed, 19 Apr 2006 13:42:34 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0A17_01C663B7.1CD0D190" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2180 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 Subject: Re: [PHP-DEV] tiny patch for Tidy From: steph@zend.com ("Steph Fox") ------=_NextPart_000_0A17_01C663B7.1CD0D190 Content-Type: text/plain; format=flowed; charset="Windows-1252"; reply-type=response Content-Transfer-Encoding: 7bit OK. I've just found that that .defs file is _only_ used by the static win32 build. It doesn't affect anything else, on any other platform. That makes fixing it even easier :) one line instead of three, you just don't export the function that doesn't exist. If/when we ever get that function in libtidy.lib, the ext/tidy (or PECL/tidy) static build will complain that it's missing - but for now they throw a fatal error _anyway_. I do realize I'm the only person in the entire universe to build extensions statically under win32 in the first place, but since we apparently have this entire defs/exports system set up to allow precisely that - what about having it working too? :) - Steph > Oops, forget it. The problem with having both PECL and src on board is I > assumed I was building against the one with this change in it. I wasn't - > I was building against the one that didn't have tidyOptGetDoc in the > export list AT ALL. > > Just ran a test and found this is illegal syntax :( so back to the drawing > board. > > (Edin: is there some way you know of to do an #ifdef equivalent in these > export lists?) > > - Steph > > > ----- Original Message ----- > From: "Steph Fox" > To: "internals" > Sent: Wednesday, April 19, 2006 12:34 PM > Subject: [PHP-DEV] tiny patch for Tidy > > >> This allows static builds under win32 despite the fact that >> tidyOptGetDoc() >> doesn't exist in the libtidy.lib we're linking against. >> >> It needs applying to php_tidy.def everywhere libtidy v 2 is used - that >> is, >> ext/tidy in CVS HEAD and PHP_5_1, and CVS HEAD pecl/tidy. >> >> In all three cases there is the same #ifdef clause for the matching >> tidy_get_opt_doc() function in the header file. >> >> - Steph >> >> >> __________ NOD32 1.1380 (20060125) Information __________ >> >> This message was checked by NOD32 antivirus system. >> http://www.eset.com >> >> > > > -------------------------------------------------------------------------------- > > >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> __________ NOD32 1.1380 (20060125) Information __________ >> >> This message was checked by NOD32 antivirus system. >> http://www.eset.com >> >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > > __________ NOD32 1.1380 (20060125) Information __________ > > This message was checked by NOD32 antivirus system. > http://www.eset.com > > ------=_NextPart_000_0A17_01C663B7.1CD0D190 Content-Type: text/plain; format=flowed; name="ext_tidy.txt"; reply-type=response Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="ext_tidy.txt" Index: ext/tidy/php_tidy.def=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /repository/php-src/ext/tidy/php_tidy.def,v=0A= retrieving revision 1.2=0A= diff -u -r1.2 php_tidy.def=0A= --- ext/tidy/php_tidy.def 25 Apr 2005 20:46:16 -0000 1.2=0A= +++ ext/tidy/php_tidy.def 19 Apr 2006 11:34:57 -0000=0A= @@ -45,7 +45,6 @@=0A= tidyOptGetDefault=0A= tidyOptGetDefaultInt=0A= tidyOptGetDefaultBool=0A= -tidyOptGetDoc=0A= tidyOptGetPickList=0A= tidyOptGetNextPick=0A= tidyOptGetValue=0A= ------=_NextPart_000_0A17_01C663B7.1CD0D190--