Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:22850
Return-Path: <nlopess@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 61707 invoked by uid 1010); 19 Apr 2006 10:42:31 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 61692 invoked from network); 19 Apr 2006 10:42:31 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 19 Apr 2006 10:42:31 -0000
X-Host-Fingerprint: 212.55.154.22 relay2.ptmail.sapo.pt Linux 2.4/2.6
Received: from ([212.55.154.22:40871] helo=sapo.pt)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id 8B/BD-19715-61416444 for <internals@lists.php.net>; Wed, 19 Apr 2006 06:42:31 -0400
Received: (qmail 23243 invoked by uid 0); 19 Apr 2006 10:42:27 -0000
Received: from unknown (HELO sapo.pt) (10.134.35.159)
	by relay2 with SMTP; 19 Apr 2006 10:42:27 -0000
Received: (qmail 545 invoked from network); 19 Apr 2006 10:42:27 -0000
X-AntiVirus: PTMail-AV 0.3.88
X-Virus-Status: Clean (0.01328 seconds)
Received: from unknown (HELO pc07653) (nunoplopes@sapo.pt@[81.193.156.122])
	(envelope-sender <nlopess@php.net>)
	by mta9 (qmail-ldap-1.03) with SMTP
	for <steph@zend.com>; 19 Apr 2006 10:42:27 -0000
Message-ID: <008b01c6639d$f39177d0$0100a8c0@pc07653>
To: "Steph Fox" <steph@zend.com>,
	"internals" <internals@lists.php.net>
Cc: "Edin" <edink@emini.dk>
References: <09f201c6639c$c8fe39f0$6602a8c0@foxbox> <0a0a01c663a0$755b4230$6602a8c0@foxbox>
Date: Wed, 19 Apr 2006 11:42:26 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="Windows-1252";
	reply-type=response
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.2869
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2869
Subject: Re: [PHP-DEV] tiny patch for Tidy
From: nlopess@php.net ("Nuno Lopes")

BTW, the libtidy could be updated :) It had a major optimization a few time 
ago (it decreased my bechmark running time by ~30%).

Nuno

----- Original Message ----- 
From: "Steph Fox" <steph@zend.com>
To: "internals" <internals@lists.php.net>
Cc: "Edin" <edink@emini.dk>
Sent: Wednesday, April 19, 2006 12:00 PM
Subject: Re: [PHP-DEV] tiny patch for Tidy


> Oops, forget it. The problem with having both PECL and src on board is I 
> assumed I was building against the one with this change in it. I wasn't - 
> I was building against the one that didn't have tidyOptGetDoc in the 
> export list AT ALL.
>
> Just ran a test and found this is illegal syntax :( so back to the drawing 
> board.
>
> (Edin: is there some way you know of to do an #ifdef equivalent in these 
> export lists?)
>
> - Steph
>
>
> ----- Original Message ----- 
> From: "Steph Fox" <steph@zend.com>
> To: "internals" <internals@lists.php.net>
> Sent: Wednesday, April 19, 2006 12:34 PM
> Subject: [PHP-DEV] tiny patch for Tidy
>
>
>> This allows static builds under win32 despite the fact that 
>> tidyOptGetDoc()
>> doesn't exist in the libtidy.lib we're linking against.
>>
>> It needs applying to php_tidy.def everywhere libtidy v 2 is used - that 
>> is,
>> ext/tidy in CVS HEAD and PHP_5_1, and CVS HEAD pecl/tidy.
>>
>> In all three cases there is the same #ifdef clause for the matching
>> tidy_get_opt_doc() function in the header file.
>>
>> - Steph