Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22646 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 61347 invoked by uid 1010); 2 Apr 2006 17:59:58 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 61332 invoked from network); 2 Apr 2006 17:59:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Apr 2006 17:59:58 -0000 X-Host-Fingerprint: 70.85.46.36 unknown Received: from ([70.85.46.36:43343] helo=prohost.org) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 0E/CB-09123-C1110344 for ; Sun, 02 Apr 2006 13:59:57 -0400 Received: (qmail 12203 invoked from network); 2 Apr 2006 17:59:53 -0000 Received: from prohost.org (HELO ?127.0.0.1?) (70.85.46.36) by prohost.org with SMTP; 2 Apr 2006 17:59:53 -0000 Message-ID: <44301118.1060902@prohost.org> Date: Sun, 02 Apr 2006 13:59:52 -0400 User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Ron Korving CC: internals@lists.php.net References: <442C3388.3000603@prohost.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: PHP 5.1.3RC2 Released From: ilia@prohost.org (Ilia Alshanetsky) The i variable inside insertionsort() is used by the swap() macro and is actually needed. The other two issues are indeed valid and patches to fix them have just been applied to CVS, thanks for pointing them out. Ilia Ron Korving wrote: > Nice to see RC2 :) > I noticed that few of my earlier observations have not been addressed > though, and these are minor cleanups, but they are cleanups: > > 1) An unused variable 'i' in insertionsort() in main/mergesort.c > 2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type: > image/gif" with 2 spaces between "Content-Type" and "image/gif" > 3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there > are 2 fprintf() calls which could just as easily be done with 1: > fprintf(stderr, "%s\n", message); > instead of: > fprintf(stderr, "%s", message); > fprintf(stderr, "\n"); > > I can't 100% guarantee that this is all safe, but it all seems(!) perfectly > safe to me. > > Regards, > > Ron > > > "Ilia Alshanetsky" wrote in message > news:442C3388.3000603@prohost.org... >> PHP 5.1.3RC2 has just been released, about a week late, but better late >> then never ;-). Please test this RC as much as possible, if it proves to >> be stable, this release will be published as final next week Thursday. >> >> The source packages can be found here: >> >> http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2 >> MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970 >> >> http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz >> MD5: 1e66780413580bc4a0742fa302735c99 >> >> Win32 binaries will be available for download shortly. >> >> Ilia >> 5.1 Release Master >