Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22642 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89146 invoked by uid 1010); 1 Apr 2006 22:07:57 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 89130 invoked from network); 1 Apr 2006 22:07:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Apr 2006 22:07:57 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:43445] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id FE/64-09123-BB9FE244 for ; Sat, 01 Apr 2006 17:07:55 -0500 Received: from localhost (strato.aixcept.de [81.169.182.136]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 0A9E835C007; Sun, 2 Apr 2006 00:07:50 +0200 (CEST) Date: Sun, 2 Apr 2006 00:07:44 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <10310117929.20060402000744@marcus-boerger.de> To: Ron Korving Cc: internals@lists.php.net In-Reply-To: <3A.6B.09123.9B1EE244@pb1.pair.com> References: <442C3388.3000603@prohost.org> <3A.6B.09123.9B1EE244@pb1.pair.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: PHP 5.1.3RC2 Released From: helly@php.net (Marcus Boerger) Hello Ron, if only these two spots were all problems we had. :-) marcus Saturday, April 1, 2006, 10:18:09 PM, you wrote: > Nice to see RC2 :) > I noticed that few of my earlier observations have not been addressed > though, and these are minor cleanups, but they are cleanups: > 1) An unused variable 'i' in insertionsort() in main/mergesort.c > 2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type: > image/gif" with 2 spaces between "Content-Type" and "image/gif" > 3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there > are 2 fprintf() calls which could just as easily be done with 1: > fprintf(stderr, "%s\n", message); > instead of: > fprintf(stderr, "%s", message); > fprintf(stderr, "\n"); > I can't 100% guarantee that this is all safe, but it all seems(!) perfectly > safe to me. > Regards, > Ron > "Ilia Alshanetsky" wrote in message > news:442C3388.3000603@prohost.org... >> PHP 5.1.3RC2 has just been released, about a week late, but better late >> then never ;-). Please test this RC as much as possible, if it proves to >> be stable, this release will be published as final next week Thursday. >> >> The source packages can be found here: >> >> http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2 >> MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970 >> >> http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz >> MD5: 1e66780413580bc4a0742fa302735c99 >> >> Win32 binaries will be available for download shortly. >> >> Ilia >> 5.1 Release Master Best regards, Marcus