Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22640 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 28045 invoked by uid 1010); 1 Apr 2006 20:21:10 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 28028 invoked from network); 1 Apr 2006 20:21:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Apr 2006 20:21:10 -0000 X-Host-Fingerprint: 83.160.219.156 korving.demon.nl Received: from ([83.160.219.156:13110] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id D1/0B-09123-5B0EE244 for ; Sat, 01 Apr 2006 15:21:09 -0500 Message-ID: To: internals@lists.php.net References: <442C3388.3000603@prohost.org> Date: Sat, 1 Apr 2006 22:18:09 +0200 Lines: 42 X-Priority: 3 X-MSMail-Priority: Normal X-Newsreader: Microsoft Outlook Express 6.00.2800.1437 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1441 X-Posted-By: 83.160.219.156 Subject: Re: PHP 5.1.3RC2 Released From: r.korving@xit.nl ("Ron Korving") Nice to see RC2 :) I noticed that few of my earlier observations have not been addressed though, and these are minor cleanups, but they are cleanups: 1) An unused variable 'i' in insertionsort() in main/mergesort.c 2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type: image/gif" with 2 spaces between "Content-Type" and "image/gif" 3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there are 2 fprintf() calls which could just as easily be done with 1: fprintf(stderr, "%s\n", message); instead of: fprintf(stderr, "%s", message); fprintf(stderr, "\n"); I can't 100% guarantee that this is all safe, but it all seems(!) perfectly safe to me. Regards, Ron "Ilia Alshanetsky" wrote in message news:442C3388.3000603@prohost.org... > PHP 5.1.3RC2 has just been released, about a week late, but better late > then never ;-). Please test this RC as much as possible, if it proves to > be stable, this release will be published as final next week Thursday. > > The source packages can be found here: > > http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2 > MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970 > > http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz > MD5: 1e66780413580bc4a0742fa302735c99 > > Win32 binaries will be available for download shortly. > > Ilia > 5.1 Release Master